Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV #122

Closed
wants to merge 11 commits into from
Closed

8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV #122

wants to merge 11 commits into from

Commits on Feb 22, 2020

  1. fix for <https://bugs.openjdk.java.net/browse/JDK-8234959> JDK-823495… 

    …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
    @ronyfla
    ronyfla committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    5c33d59 View commit details
    Browse the repository at this point in the history

  2. test for <https://bugs.openjdk.java.net/browse/JDK-8234959> JDK-82349… 

    …59: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
    @ronyfla
    ronyfla committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    e251996 View commit details
    Browse the repository at this point in the history

  3. Removed/replaced white space.

    @ronyfla
    ronyfla committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    6e4df77 View commit details
    Browse the repository at this point in the history

  4. Removed/replaced white space.

    @ronyfla
    ronyfla committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    3053959 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Incorporating Kevin Rushfort's review comments to this WIP.

    @ronyfla
    ronyfla committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8cf0a6e View commit details
    Browse the repository at this point in the history

  2. Incorporating Kevin Rushfort's review comments to this WIP.

    @ronyfla
    ronyfla committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    2db3171 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'scripttest' into script as requested by reviewer Kevin 

    Rushforth.
    @ronyfla
    ronyfla committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    799a814 View commit details
    Browse the repository at this point in the history

  4. Removed executable bit from gradlew as this causes an error when 

    pushing.
    @ronyfla
    ronyfla committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8821d25 View commit details
    Browse the repository at this point in the history

  5. corrected wrong test string

    @ronyfla
    ronyfla committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    a42fed5 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Applying the changes according to the review.

    @ronyfla
    ronyfla committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    7d867ab View commit details
    Browse the repository at this point in the history

  2. Remove jcheck whitespace error.

    @ronyfla
    ronyfla committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    58c8ce5 View commit details
    Browse the repository at this point in the history