-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8232524: SynchronizedObservableMap cannot be be protected for copying/iterating #17
Conversation
By using the collection itself as synchronization lock we achieve behaviour that matches java.util.Collections classes.
👋 Welcome back rlichten! A progress list of the required criteria for merging this PR into |
You have many whitespace errors in your patch that will need to be fixed before As an aside, you have uncovered a bug in the Skara PR bot where the server-side jcheck fails to complete if there are more than 50 errors. See SKARA-135. |
I'm trying to setup skara tools so that I can check changes before committing in the future.
OMG, hope I didn't break things ;-) |
…/iterating Whitespace fixes.
Webrevs
|
I think I have corrected the whitespace errors (I can see "All checks have passed"), is there anything else I can / should do for this pull request? |
This is now ready to be reviewed. Nothing more for you to do until there are questions or comments that arise during the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, added a comment for a small change in test.
modules/javafx.base/src/test/java/test/javafx/collections/FXCollectionsTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I can confirm that the new tests fail without the fix and pass with the fix.
@effad This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 34 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@arapte, @kevinrushforth) but any other Committer may sponsor as well.
|
Note that this is still pending a second review from @arapte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@effad you can now integrate this whenever you are ready. I will sponsor it. |
/integrate |
/sponsor |
@kevinrushforth @effad The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 46338d0. |
Mailing list message from Kevin Rushforth on openjfx-dev: Changeset: 46338d0 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating Reviewed-by: arapte, kcr ! modules/javafx.base/src/main/java/javafx/collections/FXCollections.java |
Pull from origin
By using the collection itself as synchronization lock we achieve behaviour that matches java.util.Collections classes.
I've create test cases that fail with the current way of synchronizing on a separate object.
I've removed unused constructors.
Progress
Issue
JDK-8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
Approvers