Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260257: [Linux] WebView no longer reacts to some mouse events #404

Closed
wants to merge 3 commits into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Feb 17, 2021

Timer in RunLoopGeneric has an open bug in WebKit (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain active even after firing.

Reverting back to WebCore Timer for ScrollAnimation in Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260257: [Linux] WebView no longer reacts to some mouse events

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/404/head:pull/404
$ git checkout pull/404

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2021

馃憢 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 17, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 17, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Tested on all three platforms (although it should only affect Linux). I confirm that on Linux scrolling via the trackpad (or by clicking in the scrollbar track) now works properly.

@kevinrushforth kevinrushforth requested a review from guruhb Feb 18, 2021
guruhb
guruhb approved these changes Feb 22, 2021
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me. Verified on Ubuntu 20.04

@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@arun-Joseph This change now passes all automated pre-integration checks.

鈩癸笍 This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260257: [Linux] WebView no longer reacts to some mouse events

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • dc342d3: 8262236: Configure Gradle checksum verification
  • e25d39b: 8260468: Wrong behavior of LocalDateTimeStringConverter
  • 9e42eea: 8261927: WebKit build fails with Visual Studio 2017
  • 4733824: 8252935: Add treeShowing listener only when needed
  • f02019f: 8261460: Incorrect CSS applied to ContextMenu on DialogPane
  • 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

鉃★笍 To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 22, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 23, 2021

As discussed offline, an automated test would be helpful to ensure no future regression.

@openjdk openjdk bot removed the ready label Feb 24, 2021
Copy link
Collaborator

@johanvos johanvos left a comment

Great.
The test fails before and succeeds after the patch.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

The new test looks good, although in order to make it pass on my slower Ubuntu 20.04 VM, I had to increase the sleep time to 500 ms and also add a sleep after the focus latch and before the scroll. See below.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 24, 2021

I did a little more experimenting, and the important one on my Linux VM system is the addition of the 500 ms sleep between the await on the latch and initiating the scroll. I could leave the other delay at 100 ms and it still passes for me. It may be best to increase that latter sleep to 500 anyway.

@openjdk openjdk bot added the ready label Feb 24, 2021
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Feb 24, 2021

/integrate

@openjdk openjdk bot closed this Feb 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@arun-Joseph Since your change was applied there have been 6 commits pushed to the master branch:

  • dc342d3: 8262236: Configure Gradle checksum verification
  • e25d39b: 8260468: Wrong behavior of LocalDateTimeStringConverter
  • 9e42eea: 8261927: WebKit build fails with Visual Studio 2017
  • 4733824: 8252935: Add treeShowing listener only when needed
  • f02019f: 8261460: Incorrect CSS applied to ContextMenu on DialogPane
  • 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms

Your commit was automatically rebased without conflicts.

Pushed as commit dc91f64.

馃挕 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants