8260257: [Linux] WebView no longer reacts to some mouse events

[arun-joseph]

Timer in RunLoopGeneric has an open bug in WebKit (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain active even after firing.

Reverting back to WebCore Timer for ScrollAnimation in Linux.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260257: [Linux] WebView no longer reacts to some mouse events

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Guru Hb (@guruhb - Reviewer) 🔄 Re-review required (review applies to 480c0d9)
• Johan Vos (@johanvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/404/head:pull/404
$ git checkout pull/404

[bridgekeeper]

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 02: Full - Incremental (aea2696)
• 01: Full - Incremental (903093a)
• 00: Full (480c0d9)

[kevinrushforth]

Looks good. Tested on all three platforms (although it should only affect Linux). I confirm that on Linux scrolling via the trackpad (or by clicking in the scrollbar track) now works properly.

[guruhb]

Looks good to me. Verified on Ubuntu 20.04

[openjdk]

@arun-joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260257: [Linux] WebView no longer reacts to some mouse events

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• dc342d3: 8262236: Configure Gradle checksum verification
• e25d39b: 8260468: Wrong behavior of LocalDateTimeStringConverter
• 9e42eea: 8261927: WebKit build fails with Visual Studio 2017
• 4733824: 8252935: Add treeShowing listener only when needed
• f02019f: 8261460: Incorrect CSS applied to ContextMenu on DialogPane
• 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

As discussed offline, an automated test would be helpful to ensure no future regression.

[johanvos]

Great.
The test fails before and succeeds after the patch.

[kevinrushforth]

The new test looks good, although in order to make it pass on my slower Ubuntu 20.04 VM, I had to increase the sleep time to 500 ms and also add a sleep after the focus latch and before the scroll. See below.

[kevinrushforth]

I did a little more experimenting, and the important one on my Linux VM system is the addition of the 500 ms sleep between the await on the latch and initiating the scroll. I could leave the other delay at 100 ms and it still passes for me. It may be best to increase that latter sleep to 500 anyway.

[arun-joseph]

/integrate

[openjdk]

@arun-joseph Since your change was applied there have been 6 commits pushed to the master branch:

• dc342d3: 8262236: Configure Gradle checksum verification
• e25d39b: 8260468: Wrong behavior of LocalDateTimeStringConverter
• 9e42eea: 8261927: WebKit build fails with Visual Studio 2017
• 4733824: 8252935: Add treeShowing listener only when needed
• f02019f: 8261460: Incorrect CSS applied to ContextMenu on DialogPane
• 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms

Your commit was automatically rebased without conflicts.

Pushed as commit dc91f64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.