Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319079: Missing range checks in decora #25

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 2, 2023

This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8319079
It adds appropriate range checks in native code for Box/Gaussian Blur/Shadow effects in Software pipeline.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319079 needs maintainer approval

Issue

  • JDK-8319079: Missing range checks in decora (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/jfx21u.git pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/25.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2023

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 96e5d10a40dc25b999ff229f1d6601d1058761b2 8319079: Missing range checks in decora Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

⚠️ @jayathirthrao This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Nov 2, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2023

Webrevs

@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@kevinrushforth
8319079: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319079: Missing range checks in decora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 2, 2023
@jayathirthrao
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@jayathirthrao
Your change (at version cefa4fe) is now ready to be sponsored by a Committer.

@arapte
Copy link
Member

arapte commented Nov 3, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

Going to push as commit 5f21d46.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2023
@openjdk openjdk bot closed this Nov 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@arapte @jayathirthrao Pushed as commit 5f21d46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants