6878: Update Spotbugs latest version in jmc 8.0.0 source

Reviewed-by: hirt

Author: Suchita Chaturvedi

application/tests/org.openjdk.jmc.joverflow.test/src/test/java/org/openjdk/jmc/joverflow/heap/model/TestJavaObjectTable.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2020 Oracle and/or its affiliates. All rights reserved.
  * 
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
@@ -53,7 +53,7 @@ public void testTableWithSingleObject() throws Exception {
 		JavaObjectTable table = builder.buildJavaObjectTable(classes);
 
 		JavaLazyReadObject obj = table.getObject(objPosInTable);
-		Assert.assertTrue(obj instanceof JavaObject);
+		Assert.assertTrue(JavaObject.class.isInstance(obj));
 		Assert.assertEquals(fooClass, obj.getClazz());
 		Assert.assertEquals(10, obj.getObjOfsInFile());
 	}
@@ -95,15 +95,15 @@ public void testTableWithManyObjects() throws Exception {
 			JavaLazyReadObject obj = table.getObject(objPosInTable[i]);
 
 			if (i % 2 == 0) {
-				Assert.assertTrue(obj instanceof JavaObject);
+				Assert.assertTrue(JavaObject.class.isInstance(obj));
 				Assert.assertEquals(fooClass, obj.getClazz());
 				Assert.assertFalse(obj.isVisited());
 				Assert.assertFalse(obj.isVisitedAsCollectionImpl());
 				obj.setVisited();
 				Assert.assertTrue(obj.isVisited());
 				Assert.assertFalse(obj.isVisitedAsCollectionImpl());
 			} else {
-				Assert.assertTrue(obj instanceof JavaObjectArray);
+				Assert.assertTrue(JavaObjectArray.class.isInstance(obj));
 				Assert.assertEquals(barClass, obj.getClazz());
 				Assert.assertEquals(arrLen, ((JavaObjectArray) obj).getLength());
 				Assert.assertFalse(obj.isVisited());
@@ -123,12 +123,12 @@ public void testTableWithManyObjects() throws Exception {
 			Assert.assertEquals("i = " + i, objOfsInFile, obj.getObjOfsInFile());
 
 			if (i % 2 == 0) {
-				Assert.assertTrue("i = " + i, obj instanceof JavaObject);
+				Assert.assertTrue("i = " + i, JavaObject.class.isInstance(obj));
 				Assert.assertEquals("i = " + i, fooClass, obj.getClazz());
 				Assert.assertTrue(obj.isVisited());
 				Assert.assertFalse(obj.isVisitedAsCollectionImpl());
 			} else {
-				Assert.assertTrue("i = " + i, obj instanceof JavaObjectArray);
+				Assert.assertTrue("i = " + i, JavaObjectArray.class.isInstance(obj));
 				Assert.assertEquals("i = " + i, barClass, obj.getClazz());
 				Assert.assertEquals("i = " + i, arrLen, ((JavaObjectArray) obj).getLength());
 				Assert.assertFalse(obj.isVisited());
@@ -179,10 +179,10 @@ public void testIteratingUnvisitedObjects() throws Exception {
 			Assert.assertEquals("i = " + i, objOfsInFile, obj.getObjOfsInFile());
 
 			if (i % 2 == 0) {
-				Assert.assertTrue("i = " + i, obj instanceof JavaObject);
+				Assert.assertTrue("i = " + i, JavaObject.class.isInstance(obj));
 				Assert.assertEquals("i = " + i, fooClass, obj.getClazz());
 			} else {
-				Assert.assertTrue("i = " + i, obj instanceof JavaObjectArray);
+				Assert.assertTrue("i = " + i, JavaObjectArray.class.isInstance(obj));
 				Assert.assertEquals("i = " + i, barClass, obj.getClazz());
 				Assert.assertEquals("i = " + i, arrLen, ((JavaObjectArray) obj).getLength());
 			}

pom.xml

@@ -85,7 +85,7 @@
 		<maven.resources.version>3.2.0</maven.resources.version>
 		<spotless.version>2.5.0</spotless.version>
 		<spotless.config.path>${basedir}/configuration/ide/eclipse/formatting/formatting.xml</spotless.config.path>
-		<spotbugs.version>4.0.4</spotbugs.version>
+		<spotbugs.version>4.1.4</spotbugs.version>
 		<buildId>${user.name}</buildId>
 		<!-- The version of the JDK embedded. When not embedding a JDK (this is 
 			usually the case), leave this empty. If embedding a JDK, include a comma