4819: Improved tooltips and context menus for Stack Trace View

Reviewed-by: hirt

Author: mirage22

application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

@@ -433,7 +433,7 @@ STACKTRACE_VIEW_GROUP_TRACES_FROM_ROOT=\u30B9\u30EC\u30C3\u30C9\u30FB\u30EB\u30F
 STACKTRACE_VIEW_LAST_FRAME=\u6700\u7D42\u30D5\u30EC\u30FC\u30E0
 STACKTRACE_VIEW_LAYOUT_OPTIONS=\u30EC\u30A4\u30A2\u30A6\u30C8\u30FB\u30AA\u30D7\u30B7\u30E7\u30F3
 STACKTRACE_VIEW_SELECTION=\u30B9\u30BF\u30C3\u30AF\u30FB\u30C8\u30EC\u30FC\u30B9\u30FB\u30D3\u30E5\u30FC\u306E\u9078\u629E
-STACKTRACE_VIEW_SHOW_AS_TREE=\u30C4\u30EA\u30FC\u3067\u8868\u793A
+STACKTRACE_VIEW_TREE_VIEW=\u30C4\u30EA\u30FC\u3067\u8868\u793A
 STACKTRACE_VIEW_STACK_TRACE=\u30B9\u30BF\u30C3\u30AF\u30FB\u30C8\u30EC\u30FC\u30B9
 STACKTRACE_VIEW_OPTIMIZATION_TYPE=\u6700\u9069\u5316\u30BF\u30A4\u30D7
 STACKTRACE_VIEW_REDUCE_TREE_DEPTH=\u30C4\u30EA\u30FC\u306E\u6DF1\u3055\u306E\u524A\u6E1B

application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_zh_CN.properties

@@ -433,7 +433,7 @@ STACKTRACE_VIEW_GROUP_TRACES_FROM_ROOT=\u7EC4\u8DDF\u8E2A\u81EA\u7EBF\u7A0B\u683
 STACKTRACE_VIEW_LAST_FRAME=\u4E0A\u4E00\u4E2A\u5E27
 STACKTRACE_VIEW_LAYOUT_OPTIONS=\u5E03\u5C40\u9009\u9879
 STACKTRACE_VIEW_SELECTION=\u5806\u6808\u8DDF\u8E2A\u89C6\u56FE\u9009\u62E9
-STACKTRACE_VIEW_SHOW_AS_TREE=\u663E\u793A\u4E3A\u6811
+STACKTRACE_VIEW_TREE_VIEW=\u663E\u793A\u4E3A\u6811
 STACKTRACE_VIEW_STACK_TRACE=\u5806\u6808\u8DDF\u8E2A
 STACKTRACE_VIEW_OPTIMIZATION_TYPE=\u4F18\u5316\u7C7B\u578B
 STACKTRACE_VIEW_REDUCE_TREE_DEPTH=\u51CF\u5C11\u6811\u6DF1\u5EA6

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java

@@ -463,7 +463,7 @@ public class Messages extends NLS {
 	public static String STACKTRACE_VIEW_OPTIMIZATION_TYPE;
 	public static String STACKTRACE_VIEW_REDUCE_TREE_DEPTH;
 	public static String STACKTRACE_VIEW_SELECTION;
-	public static String STACKTRACE_VIEW_SHOW_AS_TREE;
+	public static String STACKTRACE_VIEW_TREE_VIEW;
 	public static String STACKTRACE_VIEW_STACK_TRACE;
 	public static String STACKTRACE_VIEW_THREAD_ROOT;
 	public static String STACKTRACE_VIEW_TRACES_IN_GROUP;

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java

@@ -193,6 +193,7 @@ public void run() {
 	private ColumnViewer viewer;
 	private boolean treeLayout;
 	private boolean reducedTree;
+	private IAction reducedTreeAction;
 	private boolean threadRootAtTop;
 	private IItemCollection itemsToShow;
 	private MethodFormatter methodFormatter;
@@ -361,6 +362,11 @@ public void keyTraversed(TraverseEvent e) {
 
 	};
 
+	private void updateReducedTreeOption() {
+		reducedTreeAction.setEnabled(treeLayout);
+		reducedTreeAction.setChecked(reducedTree);
+	}
+
 	@Override
 	public void init(IViewSite site, IMemento memento) throws PartInitException {
 		super.init(site, memento);
@@ -370,10 +376,11 @@ public void init(IViewSite site, IMemento memento) throws PartInitException {
 		treeLayout = StateToolkit.readBoolean(state, TREE_LAYOUT_KEY, false);
 		reducedTree = StateToolkit.readBoolean(state, REDUCED_TREE_KEY, true);
 
-		IAction reducedTreeAction = ActionToolkit.checkAction(this::setReducedTree,
-				Messages.STACKTRACE_VIEW_REDUCE_TREE_DEPTH, null);
-		reducedTreeAction.setChecked(reducedTree);
-		IAction treeAction = ActionToolkit.checkAction(this::setTreeLayout, Messages.STACKTRACE_VIEW_SHOW_AS_TREE,
+		reducedTreeAction = ActionToolkit.checkAction(this::setReducedTree, Messages.STACKTRACE_VIEW_REDUCE_TREE_DEPTH,
+				null);
+		updateReducedTreeOption();
+
+		IAction treeAction = ActionToolkit.checkAction(this::setTreeLayout, Messages.STACKTRACE_VIEW_TREE_VIEW,
 				CoreImages.TREE_MODE);
 		treeAction.setChecked(treeLayout);
 		layoutActions = new IAction[] {treeAction, reducedTreeAction};
@@ -431,13 +438,15 @@ public void createPartControl(Composite parent) {
 	private void setTreeLayout(boolean treeLayout) {
 		this.treeLayout = treeLayout;
 		rebuildViewer();
+		updateReducedTreeOption();
 	}
 
 	private void setReducedTree(boolean reducedTree) {
 		this.reducedTree = reducedTree;
 		if (viewer instanceof TreeViewer) {
 			viewer.setContentProvider(createTreeContentProvider());
 		}
+		updateReducedTreeOption();
 	}
 
 	// See JMC-6787

application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties

@@ -442,7 +442,7 @@ STACKTRACE_VIEW_GROUP_TRACES_FROM_ROOT=Group traces from thread root
 STACKTRACE_VIEW_LAST_FRAME=Last Frame
 STACKTRACE_VIEW_LAYOUT_OPTIONS=Layout Options
 STACKTRACE_VIEW_SELECTION=Stack Trace View Selection
-STACKTRACE_VIEW_SHOW_AS_TREE=Show as Tree
+STACKTRACE_VIEW_TREE_VIEW=Tree View
 STACKTRACE_VIEW_STACK_TRACE=Stack Trace
 STACKTRACE_VIEW_OPTIMIZATION_TYPE=Optimization Type
 STACKTRACE_VIEW_REDUCE_TREE_DEPTH=Reduce Tree Depth

application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrStackTrace.java

@@ -61,7 +61,7 @@ public class JfrStackTrace extends MCJemmyBase {
 	private String FRAME_GROUP = "Choose Frame Group";
 	private String PREVIOUS = "Previous Frame Group";
 	private String NEXT = "Next Frame Group";
-	private String TREE = "Show as Tree";
+	private String TREE = "Tree View";
 	private String GROUP_METHOD = "Group traces from last method";
 	private String GROUP_ROOT = "Group traces from thread root";
 
@@ -392,7 +392,7 @@ public void clickNextFrameGroupButton() {
 	}
 
 	/**
-	 * Clicks the button "Show as Tree" in the toolbar
+	 * Clicks the button "Tree View" in the toolbar
 	 */
 	public void clickShowAsTreeButton() {
 		toolBar.clickToolItem(TREE);
@@ -428,7 +428,7 @@ public void setChooseFrameGroup(Boolean state) {
 	}
 
 	/**
-	 * Makes sure that the the state of the Show as tree mode corresponds with the provided value.
+	 * Makes sure that the the state of the "Tree View" mode corresponds with the provided value.
 	 *
 	 * @param state
 	 *            {@code true} if the stack trace should be displayed as a tree, {@code false} if it
@@ -444,7 +444,7 @@ public void setViewAsTree(Boolean state) {
 	}
 
 	/**
-	 * Checks if the "Show as Tree" button in the toolbar is enabled.
+	 * Checks if the "Tree View" button in the toolbar is enabled.
 	 * 
 	 * @return {@code true} if enabled, {@code false} if not
 	 */