Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8117: mvn clean install on JMC Core fails if path contains space #512

Closed
wants to merge 1 commit into from

Conversation

viragpurnam
Copy link
Collaborator

@viragpurnam viragpurnam commented Aug 17, 2023

mvn clean install on JMC Core fails if path contains space.

If there is a space in path, mvn clean install fails. Space has been replaced by %20 and it makes the path incorrect. To fix this issue URI has to be used in place of URL.
Please refer the below screen shot for error.
8117


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8117: mvn clean install on JMC Core fails if path contains space (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/512/head:pull/512
$ git checkout pull/512

Update a local copy of the PR:
$ git checkout pull/512
$ git pull https://git.openjdk.org/jmc.git pull/512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 512

View PR using the GUI difftool:
$ git pr show -t 512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/512.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back vpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8117: mvn clean install on JMC Core fails if path contains space

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 17, 2023
@viragpurnam
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit 6003efc.

@openjdk openjdk bot added the integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@viragpurnam Pushed as commit 6003efc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants