Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903318: Make -report:executed the default #123

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Sep 20, 2022

Please review this change to the default value of reportMode property.

The proposed report mode produces a report on the selected tests only; it is very fast to execute, and usually completes under a second.
The current default mode produces a report on all tests in the same test suite. It requires scanning all directories and source files in the test suite, requires a long time to produce, and usually produces the same results when jtreg is invoked from make.

If this change is integrated, the old report mode will be available under command line option -report:all-executed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/123/head:pull/123
$ git checkout pull/123

Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.org/jtreg pull/123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 123

View PR using the GUI difftool:
$ git pr show -t 123

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/123.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2022

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2022

Webrevs

@djelinski
Copy link
Member Author

This brings back the original issue that CODETOOLS-7902474 was probably meant to address. Specifically, when running:

make test TEST=tier1 JTREG=RETRY_COUNT=2

which internally reruns failed tests using -status:fail,error, jtreg report will only contain tests from the last run.

This issue could be addressed by making report:all-executed the default in jtreg when status filter is set. We could also change the jdk makefiles to explicitly add that parameter when retrying.

Alternatively, I suppose we could modify jdk makefiles to pass report:executed when not retrying, and leave jtreg unmodified. Let me know your preferences.

@shipilev
Copy link
Member

shipilev commented Sep 21, 2022

This brings back the original issue that CODETOOLS-7902474 was probably meant to address. Specifically, when running:

make test TEST=tier1 JTREG=RETRY_COUNT=2

which internally reruns failed tests using -status:fail,error, jtreg report will only contain tests from the last run.

This issue could be addressed by making report:all-executed the default in jtreg when status filter is set. We could also change the jdk makefiles to explicitly add that parameter when retrying.

Ah. Dang.

Alternatively, I suppose we could modify jdk makefiles to pass report:executed when not retrying, and leave jtreg unmodified. Let me know your preferences.

I think we can do both, but lead with JDK change to see how it works? If that works, we can default to it in jtreg? I filed https://bugs.openjdk.org/browse/JDK-8294142 for it.

@djelinski
Copy link
Member Author

Closing in favor of JDK-8294142 and CODETOOLS-7903323

@djelinski djelinski closed this Sep 23, 2022
@djelinski djelinski deleted the faster-default branch September 23, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants