Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903394: Update version to 7.1.1 #141

Closed

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Dec 5, 2022

This PR updates jtreg's version to 7.1.1 and contains the cherry-picked bugfix for:

It also updates the CHANGELOG.md accordingly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • CODETOOLS-7903394: Update version to 7.1.1
  • CODETOOLS-7903386: Update changelog for jtreg 7.1 ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
  • CODETOOLS-7903390: Summary reporter getter not thread-safe ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.org/jtreg pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/141.diff

sormuras and others added 3 commits December 5, 2022 20:06
Reviewed-by: jjg, iris
(cherry picked from commit cfa79d9)
Reviewed-by: dholmes, dcubed, jjg
(cherry picked from commit 16db696)
Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sormuras
Copy link
Member Author

sormuras commented Dec 5, 2022

/issue add 7903386

@sormuras
Copy link
Member Author

sormuras commented Dec 5, 2022

/issue add 7903390

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2022

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into branch-7.1+x will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903394: Update version to 7.1.1
7903386: Update changelog for jtreg 7.1
7903390: Summary reporter getter not thread-safe

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the branch-7.1+x branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@sormuras
Adding additional issue to issue list: 7903386: Update changelog for jtreg 7.1.

@sormuras
Copy link
Member Author

sormuras commented Dec 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@sormuras
Adding additional issue to issue list: 7903390: Summary reporter getter not thread-safe.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@sormuras
Your change (at version c7df9b5) is now ready to be sponsored by a Committer.

@mcimadamore
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit 3ea7f9f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@mcimadamore @sormuras Pushed as commit 3ea7f9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants