-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODETOOLS-7903398: Incorrect format for version in error message #143
CODETOOLS-7903398: Incorrect format for version in error message #143
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 524161b.
Your commit was automatically rebased without conflicts. |
@jonathan-gibbons Pushed as commit 524161b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a simple update to use the new format for version strings, for use in an error message.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/143/head:pull/143
$ git checkout pull/143
Update a local copy of the PR:
$ git checkout pull/143
$ git pull https://git.openjdk.org/jtreg pull/143/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 143
View PR using the GUI difftool:
$ git pr show -t 143
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/143.diff