Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903470 jtreg AgentServer log() does not flush #156

Closed
wants to merge 2 commits into from

Conversation

LudwikJaniuk
Copy link

@LudwikJaniuk LudwikJaniuk commented May 10, 2023

Please review this change to start flushing logs on every message in AgentServer.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.org/jtreg.git pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/156.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2023

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2023
@mlbridge
Copy link

mlbridge bot commented May 10, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 10, 2023

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903470: jtreg AgentServer log() does not flush

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@LudwikJaniuk
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@LudwikJaniuk
Your change (at version 90ad35c) is now ready to be sponsored by a Committer.

@sormuras
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 11, 2023

Going to push as commit 44172fc.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2023
@openjdk openjdk bot closed this May 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@sormuras @LudwikJaniuk Pushed as commit 44172fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants