-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903519: adding jtharness crashonly extension compatibility #164
Conversation
Hi @andrlos, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user andrlos" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
@@ -260,6 +260,8 @@ help.main.nativepath.arg=<path> | |||
help.main.nativepath.desc=Path to location of native libraries and programs needed \ | |||
by the tests. | |||
|
|||
help.main.crashonly.desc=Ignores regular failures and only reports crashes as failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What it does with passes? they are reported as pass even if there si crash, right? So maybe
Only consider test as failed if it was both failed and JVM crashed during execution
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, right.. that sounds better honestly :D
An https://bugs.openjdk.org/browse/CODETOOLS-7903519 was created for this enhancement |
Webrevs
|
…first attempt to trigger the extension, reporting is not ok yet
@andrlos This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
sync with master
I want to add functionality of openjdk/jtharness#49 to jtreg, which means that this needs to be merged only after the mentioned MR is merged and tested only with a build of https://github.com/andrlos/jtharness .
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/164/head:pull/164
$ git checkout pull/164
Update a local copy of the PR:
$ git checkout pull/164
$ git pull https://git.openjdk.org/jtreg.git pull/164/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 164
View PR using the GUI difftool:
$ git pr show -t 164
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/164.diff
Webrev
Link to Webrev Comment