Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903519: adding jtharness crashonly extension compatibility #164

Closed
wants to merge 5 commits into from

Conversation

andrlos
Copy link

@andrlos andrlos commented Aug 7, 2023

I want to add functionality of openjdk/jtharness#49 to jtreg, which means that this needs to be merged only after the mentioned MR is merged and tested only with a build of https://github.com/andrlos/jtharness .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue CODETOOLS-7903519

Issue

  • CODETOOLS-7903519: jtreg/jtharness is missing features for basic crash testing (Enhancement - P3) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/164/head:pull/164
$ git checkout pull/164

Update a local copy of the PR:
$ git checkout pull/164
$ git pull https://git.openjdk.org/jtreg.git pull/164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 164

View PR using the GUI difftool:
$ git pr show -t 164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/164.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 7, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 7, 2023

Hi @andrlos, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user andrlos" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

⚠️ @andrlos a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master b9c6dcd3e87bfa9017ec6a485ca3917b0cfec997
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Aug 10, 2023
@@ -260,6 +260,8 @@ help.main.nativepath.arg=<path>
help.main.nativepath.desc=Path to location of native libraries and programs needed \
by the tests.

help.main.crashonly.desc=Ignores regular failures and only reports crashes as failures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it does with passes? they are reported as pass even if there si crash, right? So maybe

Only consider test as failed if it was both failed and JVM crashed during execution

wdyt?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, right.. that sounds better honestly :D

@judovana
Copy link
Contributor

An https://bugs.openjdk.org/browse/CODETOOLS-7903519 was created for this enhancement

@andrlos andrlos changed the title adding jtharness crashonly extension compatibility 7903519: adding jtharness crashonly extension compatibility Aug 15, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 15, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2023

Webrevs

…first attempt to trigger the extension, reporting is not ok yet
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2023

@andrlos This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andrlos andrlos closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
3 participants