Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903055: Replace junit.jar with junit-platform-console-standalone artifact #63

Closed
wants to merge 5 commits into from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Mar 3, 2022

https://bugs.openjdk.java.net/browse/CODETOOLS-7903055


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • CODETOOLS-7903055: Replace junit.jar with junit-platform-console-standalone artifact

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtreg pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.java.net/jtreg pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jtreg/pull/63.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2022

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sormuras sormuras changed the title Replace junit.jar with junit-platform-console-standalone artifact 7903055: Replace junit.jar with junit-platform-console-standalone artifact Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903055: Replace `junit.jar` with `junit-platform-console-standalone` artifact

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • dec2a59: 7903159: Make jtreg self-tests run on Windows/Cygwin
  • b498d9e: 7903155: replace single use of rsync with cp -R
  • 266576a: 7903152: On macOS, avoid using /usr/bin/tidy
  • ff5d2b9: 7903150: Restructure generated files for jtreg self-tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2022

Webrevs

Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try and retain the full base name of the JUnit jar file(s). This is used and displayed as part of the jtreg version info.

make/build.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sormuras
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@sormuras
Your change (at version def5a14) is now ready to be sponsored by a Committer.

@jonathan-gibbons
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 22, 2022

Going to push as commit e7a8de6.
Since your change was applied there have been 4 commits pushed to the master branch:

  • dec2a59: 7903159: Make jtreg self-tests run on Windows/Cygwin
  • b498d9e: 7903155: replace single use of rsync with cp -R
  • 266576a: 7903152: On macOS, avoid using /usr/bin/tidy
  • ff5d2b9: 7903150: Restructure generated files for jtreg self-tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2022
@openjdk openjdk bot closed this Apr 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 22, 2022
@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@jonathan-gibbons @sormuras Pushed as commit e7a8de6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the 7903055-junit5 branch April 22, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants