-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903138: os.simpleArch is x64 for linux-riscv64 in @require context #66
Conversation
👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into |
@feilongjiang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Could someone take a look please? |
@jonathan-gibbons Thanks for the review! Conflict with #64 was resolved. |
@feilongjiang |
Gently ping, this PR has been ready for a while. Could someone sponsor it to merge? |
@jonathan-gibbons -- would you like to sponsor this? Or should I do this? |
It's a very useful patch for me, thanks! : ) |
Merged master, could someone help me to sponsor this PR? |
Skara has dropped the @feilongjiang needs to enter |
/integrate |
@feilongjiang |
Hi @jonathan-gibbons, |
Hi, I see this patch still applies. Could we get this merged so that it will helps everyone? Thanks. |
/sponsor |
@jonathan-gibbons @feilongjiang Pushed as commit ef044d2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
RISC-V Port has been integrated into JDK mainline recently (JDK-8276799). Set simpleArch to riscv64 when os.arch is riscv64
Tested on Linux riscv64. With the patch, test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java was successfully skipped.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/66/head:pull/66
$ git checkout pull/66
Update a local copy of the PR:
$ git checkout pull/66
$ git pull https://git.openjdk.org/jtreg pull/66/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 66
View PR using the GUI difftool:
$ git pr show -t 66
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/66.diff