Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903138: os.simpleArch is x64 for linux-riscv64 in @require context #66

Closed
wants to merge 5 commits into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Mar 29, 2022

RISC-V Port has been integrated into JDK mainline recently (JDK-8276799). Set simpleArch to riscv64 when os.arch is riscv64

Tested on Linux riscv64. With the patch, test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java was successfully skipped.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/66/head:pull/66
$ git checkout pull/66

Update a local copy of the PR:
$ git checkout pull/66
$ git pull https://git.openjdk.org/jtreg pull/66/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 66

View PR using the GUI difftool:
$ git pr show -t 66

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/66.diff

@feilongjiang feilongjiang changed the title os.simpleArch is x64 for linux-riscv64 in @require context 7903138: os.simpleArch is x64 for linux-riscv64 in @require context Mar 29, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903138: os.simpleArch is x64 for linux-riscv64 in @require context

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

@feilongjiang
Copy link
Member Author

Could someone take a look please?

@feilongjiang
Copy link
Member Author

@jonathan-gibbons Thanks for the review! Conflict with #64 was resolved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 17, 2022
@openjdk
Copy link

openjdk bot commented May 17, 2022

@feilongjiang
Your change (at version a32fbd7) is now ready to be sponsored by a Committer.

@feilongjiang
Copy link
Member Author

feilongjiang commented Jul 12, 2022

Gently ping, this PR has been ready for a while. Could someone sponsor it to merge?

@shipilev
Copy link
Member

shipilev commented Sep 6, 2022

@jonathan-gibbons -- would you like to sponsor this? Or should I do this?

@DingliZhang
Copy link
Member

It's a very useful patch for me, thanks! : )

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Dec 10, 2022
@feilongjiang
Copy link
Member Author

Merged master, could someone help me to sponsor this PR?

@jonathan-gibbons
Copy link
Collaborator

Skara has dropped the sponsor label.

@feilongjiang needs to enter /integrate again, before this can be sponsored.

@feilongjiang
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 11, 2022
@openjdk
Copy link

openjdk bot commented Dec 11, 2022

@feilongjiang
Your change (at version 1fea0e4) is now ready to be sponsored by a Committer.

@feilongjiang
Copy link
Member Author

Skara has dropped the sponsor label.

@feilongjiang needs to enter /integrate again, before this can be sponsored.

Hi @jonathan-gibbons, sponsor is back, could you please sponsor this PR?

@RealFYang
Copy link
Member

RealFYang commented Jan 21, 2023

Hi, I see this patch still applies. Could we get this merged so that it will helps everyone? Thanks.

@jonathan-gibbons
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

Going to push as commit ef044d2.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 833786a: 7903406: Update jtreg to bundle JUnit 5.9.2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2023
@openjdk openjdk bot closed this Jan 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@jonathan-gibbons @feilongjiang Pushed as commit ef044d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the riscv64-simplearch branch February 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants