7903166: jtreg crashes trying to compile .jasm with enablePreview=true

[lepestock]

The bug: CODETOOLS-7903166

A small fix targeting crashes that occurs when jtreg compiles non-javac files with enablePreview. Prior the fix, the code crashed trying to insert arguments into javacArgs list using negative index.

Testing: test/preview folder self-tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• CODETOOLS-7903166: jtreg crashes trying to compile .jasm with enablePreview=true

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtreg pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.java.net/jtreg pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jtreg/pull/77.diff

[bridgekeeper]

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lepestock This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903166: jtreg crashes trying to compile .jasm with enablePreview=true

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• ba60f75: 7903172: Change invocation of GitHub Actions
• bc75e5f: 7903151: NPE when resolving @library from jtreg plugin
• c415cd0: 7903168: Update openjdk/jtreg repo to require 1 Reviewer
• 7966ad0: 7903171: Fix issues related to generating internal API documentation
• e7a8de6: 7903055: Replace junit.jar with junit-platform-console-standalone artifact
• dec2a59: 7903159: Make jtreg self-tests run on Windows/Cygwin
• b498d9e: 7903155: replace single use of rsync with cp -R
• 266576a: 7903152: On macOS, avoid using /usr/bin/tidy

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (96230a3b)
• 00: Full (994d0aee)

[jonathan-gibbons]

Good catch; one improvement suggested.

[jonathan-gibbons]

LGTM

You need to add /integrate and then I can /sponsor it

[lepestock]

/integrate

[openjdk]

@lepestock
Your change (at version 96230a3) is now ready to be sponsored by a Committer.

[jonathan-gibbons]

/sponsor

[openjdk]

Going to push as commit ac84608.
Since your change was applied there have been 11 commits pushed to the master branch:

• 7767297: 7903183: Log start time for every action
• 5e69221: 7903185: Update RerunTest for latest JUnit
• 9c4029f: 7903184: Update OS version check
• ba60f75: 7903172: Change invocation of GitHub Actions
• bc75e5f: 7903151: NPE when resolving @library from jtreg plugin
• c415cd0: 7903168: Update openjdk/jtreg repo to require 1 Reviewer
• 7966ad0: 7903171: Fix issues related to generating internal API documentation
• e7a8de6: 7903055: Replace junit.jar with junit-platform-console-standalone artifact
• dec2a59: 7903159: Make jtreg self-tests run on Windows/Cygwin
• b498d9e: 7903155: replace single use of rsync with cp -R
• ... and 1 more: https://git.openjdk.java.net/jtreg/compare/ff5d2b94627bbfef8942807f66a99336faabf9d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons @lepestock Pushed as commit ac84608.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.