-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODETOOLS-7903184: Update OS version check #83
CODETOOLS-7903184: Update OS version check #83
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and supersedes https://github.com/openjdk/jtreg/pull/75/files#diff-a5a4da5948aa7c272080a329f721f8095d1802b11821e6c11970ffc3585a4c9c
Do you want to include the comment from the linked solution?
// The os.version property may be more detailed than the expected value determined in the makefiles.
// For example, "11.6.5" is a valid match for an expected "11.6" version.
/integrate |
Going to push as commit 9c4029f. |
@jonathan-gibbons Pushed as commit 9c4029f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a small fix to be slightly more permissive in the check for the os.version property, and allow a double-dotted number (like 1.2.3) to be accepted as better than a single-dotted prefix (like 1.2).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtreg pull/83/head:pull/83
$ git checkout pull/83
Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jtreg pull/83/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 83
View PR using the GUI difftool:
$ git pr show -t 83
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jtreg/pull/83.diff