-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903206: Support MSYS2 for building jtreg on Windows #88
Conversation
Reviewed-by: ihse, jjg (cherry picked from commit d60381d)
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
@sormuras This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
You may need to file a back port request, since the original issue (to update 7) has now been closed. There are also some warnings from the bots that you should check. |
As Skara doesn't manage versions of jtreg (it lacks a version configured in The warning only addresses a naming conflict detected for my personal fork - which I tend to ignore, as I won't sync that branch in the future. In the light of that, I will issue a |
/integrate |
/sponsor |
Going to push as commit 382fe54. |
@jonathan-gibbons @sormuras Pushed as commit 382fe54. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Going forward, I think it would be better to lean into Skara some more, and configure a version in .jcheck/conf |
Reviewed-by: ihse, jjg
(cherry picked from commit d60381d)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/88/head:pull/88
$ git checkout pull/88
Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.org/jtreg pull/88/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 88
View PR using the GUI difftool:
$ git pr show -t 88
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/88.diff