-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODETOOLS-7903221: broken self-tests #90
CODETOOLS-7903221: broken self-tests #90
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit fb76dae. |
@jonathan-gibbons Pushed as commit fb76dae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a couple of test changes to make them more robust in the face of using alternate locations for the build directory, and choice of JUnit library
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/90/head:pull/90
$ git checkout pull/90
Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.org/jtreg pull/90/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 90
View PR using the GUI difftool:
$ git pr show -t 90
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/90.diff