8249144: Potential memory leak in TypedMethodOptionMatcher

zhengyu123 · zhengyu123 · commit 84429cd944b7 · 2020-11-23T13:44:43.000Z
Reviewed-by: thartmann
diff --git a/src/hotspot/share/compiler/compilerOracle.cpp b/src/hotspot/share/compiler/compilerOracle.cpp
@@ -247,6 +247,11 @@ TypedMethodOptionMatcher* TypedMethodOptionMatcher::clone() {
 }
 
 TypedMethodOptionMatcher::~TypedMethodOptionMatcher() {
+  if (type() == CcstrType) {
+    ccstr v = value<ccstr>();
+    os::free((void*)v);
+  }
+
   if (_option != NULL) {
     os::free((void*)_option);
   }

Original file line number	Diff line number	Diff line change
`@@ -247,6 +247,11 @@ TypedMethodOptionMatcher* TypedMethodOptionMatcher::clone() {`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`TypedMethodOptionMatcher::~TypedMethodOptionMatcher() {`
	`250`	`+ if (type() == CcstrType) {`
	`251`	`+ ccstr v = value<ccstr>();`
	`252`	`+ os::free((void*)v);`
	`253`	`+ }`
	`254`	`+`
`250`	`255`	`if (_option != NULL) {`
`251`	`256`	`os::free((void*)_option);`
`252`	`257`	`}`