Skip to content

Commit a1bbfc6

Browse files
author
duke
committed
Automatic merge of jdk:master into master
2 parents ae7026c + f751738 commit a1bbfc6

File tree

5 files changed

+46
-46
lines changed

5 files changed

+46
-46
lines changed

src/hotspot/share/gc/z/zHeap.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,13 @@ void ZHeap::process_non_strong_references() {
361361
_reference_processor.enqueue_references();
362362
}
363363

364-
void ZHeap::free_garbage_pages(ZRelocationSetSelector* selector, int bulk) {
365-
// Freeing garbage pages in bulk is an optimization to avoid grabbing
364+
void ZHeap::free_empty_pages(ZRelocationSetSelector* selector, int bulk) {
365+
// Freeing empty pages in bulk is an optimization to avoid grabbing
366366
// the page allocator lock, and trying to satisfy stalled allocations
367367
// too frequently.
368-
if (selector->should_free_garbage_pages(bulk)) {
369-
free_pages(selector->garbage_pages(), true /* reclaimed */);
370-
selector->clear_garbage_pages();
368+
if (selector->should_free_empty_pages(bulk)) {
369+
free_pages(selector->empty_pages(), true /* reclaimed */);
370+
selector->clear_empty_pages();
371371
}
372372
}
373373

@@ -388,16 +388,16 @@ void ZHeap::select_relocation_set() {
388388
// Register live page
389389
selector.register_live_page(page);
390390
} else {
391-
// Register garbage page
392-
selector.register_garbage_page(page);
391+
// Register empty page
392+
selector.register_empty_page(page);
393393

394-
// Reclaim garbage pages in bulk
395-
free_garbage_pages(&selector, 64 /* bulk */);
394+
// Reclaim empty pages in bulk
395+
free_empty_pages(&selector, 64 /* bulk */);
396396
}
397397
}
398398

399-
// Reclaim remaining garbage pages
400-
free_garbage_pages(&selector, 0 /* bulk */);
399+
// Reclaim remaining empty pages
400+
free_empty_pages(&selector, 0 /* bulk */);
401401

402402
// Allow pages to be deleted
403403
_page_allocator.disable_deferred_delete();

src/hotspot/share/gc/z/zHeap.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class ZHeap {
6565
void flip_to_marked();
6666
void flip_to_remapped();
6767

68-
void free_garbage_pages(ZRelocationSetSelector* selector, int bulk);
68+
void free_empty_pages(ZRelocationSetSelector* selector, int bulk);
6969

7070
void out_of_memory();
7171

src/hotspot/share/gc/z/zRelocationSetSelector.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ ZRelocationSetSelectorGroup::ZRelocationSetSelectorGroup(const char* name,
5050
_page_size(page_size),
5151
_object_size_limit(object_size_limit),
5252
_fragmentation_limit(page_size * (ZFragmentationLimit / 100)),
53-
_registered_pages(),
53+
_live_pages(),
5454
_forwarding_entries(0),
5555
_stats() {}
5656

@@ -65,7 +65,7 @@ bool ZRelocationSetSelectorGroup::is_selectable() {
6565
}
6666

6767
void ZRelocationSetSelectorGroup::semi_sort() {
68-
// Semi-sort registered pages by live bytes in ascending order
68+
// Semi-sort live pages by number of live bytes in ascending order
6969
const size_t npartitions_shift = 11;
7070
const size_t npartitions = (size_t)1 << npartitions_shift;
7171
const size_t partition_size = _page_size >> npartitions_shift;
@@ -75,7 +75,7 @@ void ZRelocationSetSelectorGroup::semi_sort() {
7575
int partitions[npartitions] = { /* zero initialize */ };
7676

7777
// Calculate partition slots
78-
ZArrayIterator<ZPage*> iter1(&_registered_pages);
78+
ZArrayIterator<ZPage*> iter1(&_live_pages);
7979
for (ZPage* page; iter1.next(&page);) {
8080
const size_t index = page->live_bytes() >> partition_size_shift;
8181
partitions[index]++;
@@ -90,26 +90,26 @@ void ZRelocationSetSelectorGroup::semi_sort() {
9090
}
9191

9292
// Allocate destination array
93-
const int npages = _registered_pages.length();
94-
ZArray<ZPage*> sorted_pages(npages, npages, NULL);
93+
const int npages = _live_pages.length();
94+
ZArray<ZPage*> sorted_live_pages(npages, npages, NULL);
9595

9696
// Sort pages into partitions
97-
ZArrayIterator<ZPage*> iter2(&_registered_pages);
97+
ZArrayIterator<ZPage*> iter2(&_live_pages);
9898
for (ZPage* page; iter2.next(&page);) {
9999
const size_t index = page->live_bytes() >> partition_size_shift;
100100
const int finger = partitions[index]++;
101-
assert(sorted_pages.at(finger) == NULL, "Invalid finger");
102-
sorted_pages.at_put(finger, page);
101+
assert(sorted_live_pages.at(finger) == NULL, "Invalid finger");
102+
sorted_live_pages.at_put(finger, page);
103103
}
104104

105-
_registered_pages.swap(&sorted_pages);
105+
_live_pages.swap(&sorted_live_pages);
106106
}
107107

108108
void ZRelocationSetSelectorGroup::select_inner() {
109109
// Calculate the number of pages to relocate by successively including pages in
110110
// a candidate relocation set and calculate the maximum space requirement for
111111
// their live objects.
112-
const int npages = _registered_pages.length();
112+
const int npages = _live_pages.length();
113113
int selected_from = 0;
114114
int selected_to = 0;
115115
size_t selected_forwarding_entries = 0;
@@ -120,7 +120,7 @@ void ZRelocationSetSelectorGroup::select_inner() {
120120

121121
for (int from = 1; from <= npages; from++) {
122122
// Add page to the candidate relocation set
123-
ZPage* const page = _registered_pages.at(from - 1);
123+
ZPage* const page = _live_pages.at(from - 1);
124124
from_live_bytes += page->live_bytes();
125125
from_forwarding_entries += ZForwarding::nentries(page);
126126

@@ -150,7 +150,7 @@ void ZRelocationSetSelectorGroup::select_inner() {
150150
}
151151

152152
// Finalize selection
153-
_registered_pages.trunc_to(selected_from);
153+
_live_pages.trunc_to(selected_from);
154154
_forwarding_entries = selected_forwarding_entries;
155155

156156
// Update statistics
@@ -181,7 +181,7 @@ ZRelocationSetSelector::ZRelocationSetSelector() :
181181
_small("Small", ZPageTypeSmall, ZPageSizeSmall, ZObjectSizeLimitSmall),
182182
_medium("Medium", ZPageTypeMedium, ZPageSizeMedium, ZObjectSizeLimitMedium),
183183
_large("Large", ZPageTypeLarge, 0 /* page_size */, 0 /* object_size_limit */),
184-
_garbage_pages() {}
184+
_empty_pages() {}
185185

186186
void ZRelocationSetSelector::select() {
187187
// Select pages to relocate. The resulting relocation set will be

src/hotspot/share/gc/z/zRelocationSetSelector.hpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZRelocationSetSelectorGroup {
7474
const size_t _page_size;
7575
const size_t _object_size_limit;
7676
const size_t _fragmentation_limit;
77-
ZArray<ZPage*> _registered_pages;
77+
ZArray<ZPage*> _live_pages;
7878
size_t _forwarding_entries;
7979
ZRelocationSetSelectorGroupStats _stats;
8080

@@ -90,7 +90,7 @@ class ZRelocationSetSelectorGroup {
9090
size_t object_size_limit);
9191

9292
void register_live_page(ZPage* page);
93-
void register_garbage_page(ZPage* page);
93+
void register_empty_page(ZPage* page);
9494
void select();
9595

9696
const ZArray<ZPage*>* selected() const;
@@ -104,7 +104,7 @@ class ZRelocationSetSelector : public StackObj {
104104
ZRelocationSetSelectorGroup _small;
105105
ZRelocationSetSelectorGroup _medium;
106106
ZRelocationSetSelectorGroup _large;
107-
ZArray<ZPage*> _garbage_pages;
107+
ZArray<ZPage*> _empty_pages;
108108

109109
size_t total() const;
110110
size_t empty() const;
@@ -115,11 +115,11 @@ class ZRelocationSetSelector : public StackObj {
115115
ZRelocationSetSelector();
116116

117117
void register_live_page(ZPage* page);
118-
void register_garbage_page(ZPage* page);
118+
void register_empty_page(ZPage* page);
119119

120-
bool should_free_garbage_pages(int bulk) const;
121-
const ZArray<ZPage*>* garbage_pages() const;
122-
void clear_garbage_pages();
120+
bool should_free_empty_pages(int bulk) const;
121+
const ZArray<ZPage*>* empty_pages() const;
122+
void clear_empty_pages();
123123

124124
void select();
125125

src/hotspot/share/gc/z/zRelocationSetSelector.inline.hpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ inline void ZRelocationSetSelectorGroup::register_live_page(ZPage* page) {
7575
const size_t garbage = size - live;
7676

7777
if (garbage > _fragmentation_limit) {
78-
_registered_pages.append(page);
78+
_live_pages.append(page);
7979
}
8080

8181
_stats._npages++;
@@ -84,7 +84,7 @@ inline void ZRelocationSetSelectorGroup::register_live_page(ZPage* page) {
8484
_stats._garbage += garbage;
8585
}
8686

87-
inline void ZRelocationSetSelectorGroup::register_garbage_page(ZPage* page) {
87+
inline void ZRelocationSetSelectorGroup::register_empty_page(ZPage* page) {
8888
const size_t size = page->size();
8989

9090
_stats._npages++;
@@ -94,7 +94,7 @@ inline void ZRelocationSetSelectorGroup::register_garbage_page(ZPage* page) {
9494
}
9595

9696
inline const ZArray<ZPage*>* ZRelocationSetSelectorGroup::selected() const {
97-
return &_registered_pages;
97+
return &_live_pages;
9898
}
9999

100100
inline size_t ZRelocationSetSelectorGroup::forwarding_entries() const {
@@ -117,30 +117,30 @@ inline void ZRelocationSetSelector::register_live_page(ZPage* page) {
117117
}
118118
}
119119

120-
inline void ZRelocationSetSelector::register_garbage_page(ZPage* page) {
120+
inline void ZRelocationSetSelector::register_empty_page(ZPage* page) {
121121
const uint8_t type = page->type();
122122

123123
if (type == ZPageTypeSmall) {
124-
_small.register_garbage_page(page);
124+
_small.register_empty_page(page);
125125
} else if (type == ZPageTypeMedium) {
126-
_medium.register_garbage_page(page);
126+
_medium.register_empty_page(page);
127127
} else {
128-
_large.register_garbage_page(page);
128+
_large.register_empty_page(page);
129129
}
130130

131-
_garbage_pages.append(page);
131+
_empty_pages.append(page);
132132
}
133133

134-
inline bool ZRelocationSetSelector::should_free_garbage_pages(int bulk) const {
135-
return _garbage_pages.length() >= bulk && _garbage_pages.is_nonempty();
134+
inline bool ZRelocationSetSelector::should_free_empty_pages(int bulk) const {
135+
return _empty_pages.length() >= bulk && _empty_pages.is_nonempty();
136136
}
137137

138-
inline const ZArray<ZPage*>* ZRelocationSetSelector::garbage_pages() const {
139-
return &_garbage_pages;
138+
inline const ZArray<ZPage*>* ZRelocationSetSelector::empty_pages() const {
139+
return &_empty_pages;
140140
}
141141

142-
inline void ZRelocationSetSelector::clear_garbage_pages() {
143-
return _garbage_pages.clear();
142+
inline void ZRelocationSetSelector::clear_empty_pages() {
143+
return _empty_pages.clear();
144144
}
145145

146146
inline size_t ZRelocationSetSelector::total() const {

0 commit comments

Comments
 (0)