[PRE REVIEW]: getTBinR: an R package for accessing and summarising the World Health Organisation Tuberculosis data #1219

whedon · 2019-01-29T20:03:44Z

Submitting author: @seabbs (Sam Abbott)
Repository: https://github.com/seabbs/getTBinR
Version: v0.5.7
Editor: @trallard
Reviewers: @rrrlw, @strengejacke

Author instructions

Thanks for submitting your paper to JOSS @seabbs. The JOSS editor Pending, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@seabbs if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

The text was updated successfully, but these errors were encountered:

whedon · 2019-01-29T20:03:47Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon · 2019-01-29T20:03:47Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-01-29T20:04:03Z

PDF failed to compile for issue #1219 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1219/inst/paper/paper.md): mapping values are not allowed in this context at line 16 column 33 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon.rb:68:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/bin/whedon:52:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/bin/whedon:113:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

danielskatz · 2019-01-29T20:16:44Z

@seabbs - once you've made changes (as in
seabbs/getTBinR#52), type @whedon generate pdf as a new comment here to retry the compilation

seabbs · 2019-01-30T10:23:10Z

@whedon generate pdf

danielskatz · 2019-01-30T11:04:41Z

I'm not sure why that didn't work - let's try again (and notify @arfon as well)

danielskatz · 2019-01-30T11:04:46Z

@whedon generate pdf

whedon · 2019-01-30T11:04:49Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-01-30T11:05:06Z

PDF failed to compile for issue #1219 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1219/inst/paper/paper.md): mapping values are not allowed in this context at line 16 column 34 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon.rb:68:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/bin/whedon:52:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/bin/whedon:113:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

seabbs · 2019-01-30T11:08:11Z

Looks like I had a : that was causing issues. Hopefully fixed now

@whedon generate pdf

danielskatz · 2019-01-30T11:09:21Z

you definitely need to make the command the first thing in a comment - can you try again?

seabbs · 2019-01-30T11:10:02Z

@whedon generate pdf

whedon · 2019-01-30T11:10:04Z

Attempting PDF compilation. Reticulating splines etc...

danielskatz · 2019-01-30T11:10:32Z

good - not sure why the command didn't work for you the other time. Maybe whedon was misbehaving...

whedon · 2019-01-30T11:10:53Z

👉 Check article proof 📄 👈

danielskatz · 2019-01-30T13:57:32Z

👋 @trallard - would you be willing to edit this submission?

trallard · 2019-01-30T16:02:39Z

sure thing @danielskatz

danielskatz · 2019-01-30T17:49:15Z

@whedon assign @trallard as editor

whedon · 2019-01-30T17:49:25Z

OK, the editor is @trallard

seabbs · 2019-02-11T13:21:09Z

Is there anything I can do to help move this along?

trallard · 2019-02-11T13:49:19Z

🙋🏻‍♀️ Hi @seabbs (sorry for the delayed action) I will be performing the editorial duties for this submission. If you have any questions over the review process please feel free to @ me.

The first step is to find suitable reviewers for this submission. Have you got any suitable people in mind? Otherwise, you can check the list of reviewers we have and suggest a few here.

trallard · 2019-02-11T13:50:10Z

@whedon list reviewers

whedon · 2019-02-11T13:50:13Z

Here's the current list of reviewers: https://bit.ly/joss-reviewers

seabbs · 2019-02-11T14:14:41Z

Hi @trallard - no problem.

No external people in mind. Looking at the list (from bottom to top) here are a few that looked relevant (in no particular order):

stulacy (R + epidemiology)
rrrlw (R + Data visualisation + Epidemiology)
strengejacke (R + Epidemiology + Data visualisation)
aj2duncan (R + Epidemiology)
patatefritte (R + Epidemiology)
ellessenne (R + Epidemiology)
ibontama (R + Epidemiology)
rosap (R + Epidemiology
simonthelwall (R + Epidemiology + Infectious disease)*
darokun (R + Epidemiology + Public Health)*
petermacp (R + Epidemiology + Infectious disease)*
noamross (R + Epidemiology)
masalmon (R + Epidemiology) *

* indicate people that look like they have R experience, are generally active in epidemiology, and have done work on infectious disease.

Hope that helps - let me know if you need anything more.

seabbs · 2019-02-15T10:28:29Z

@trallard

I was wondering if It was okay to do development work whilst awaiting/under review? I have the next version changes prepped and just waiting on this to implement (some time has come up whilst I avoid writing my thesis :)).

Thanks!

trallard · 2019-02-16T13:20:12Z

Dear reviewers,

@stulacy Stuart are you able and willing to take this review?
@rrrlw Raul are you able and willing to take this review?
@strengejacke Daniel are you able and willing to take this review?
@noamross Noam are you able and willing to take this review?
@maelle MaëlleMaëlle are you able and willing to take this review?
@darokun Daloha are you able and willing to take this review?

Title: Get TB Data in R
Summary: Quickly and easily import analysis ready TB burden data, from the World Health Organisation (WHO), into R. The aim of the package is to speed up access to high quality TB burden data, using a simple R interface. Generic plotting functions are provided to allow for rapid graphical exploration of the WHO TB data.
Article Proof: https://github.com/openjournals/joss-papers/blob/joss.01219/joss.01219/10.21105.joss.01219.pdf
Submitting author: @seabbs
Repository: https://github.com/seabbs/getTBinR

trallard · 2019-02-16T13:21:04Z

@seabbs yes that is perfectly fine, we will just update the version after those improvements and the review

Once two or more reviewers have agreed to help out we can proceed with the review process

rrrlw · 2019-02-16T13:31:28Z

I would be happy to review this submission.

trallard · 2019-02-18T17:34:41Z

thanks @rrrlw

trallard · 2019-02-18T17:35:36Z

@whedon set @rrrlw as reviewer

strengejacke · 2019-02-18T17:57:38Z

I also have time and could review this submission!

arfon · 2019-02-18T18:56:59Z

@whedon set @rrrlw as reviewer

@trallard - you want @whedon add @rrrlw as reviewer <- (or assign rather than add)

trallard · 2019-02-18T19:01:59Z

@whedon assign @rrrlw as reviewer

whedon · 2019-02-18T19:02:05Z

OK, the reviewer is @rrrlw

trallard · 2019-02-18T19:02:21Z

@whedon add @strengejacke as reviewer

whedon · 2019-02-18T19:02:26Z

OK, @strengejacke is now a reviewer

trallard · 2019-02-18T19:04:16Z

@whedon start review

whedon · 2019-02-18T19:04:20Z

OK, I've started the review over in #1260. Feel free to close this issue now!

trallard · 2019-02-18T19:04:43Z

Thanks, @arfon 🤦🏻‍♀️ I sometimes get the commands mixed up

Now that we have two reviewers we are ready to proceed with the formal review so let's move over to the review issue!

whedon added the pre-review label Jan 29, 2019

whedon added Makefile R TeX labels Jan 29, 2019

arfon mentioned this issue Jan 29, 2019

Fixing paper metadata seabbs/getTBinR#52

Merged

whedon assigned trallard Jan 30, 2019

whedon assigned rrrlw and trallard and unassigned trallard Feb 18, 2019

whedon assigned rrrlw, strengejacke and trallard and unassigned rrrlw and trallard Feb 18, 2019

trallard closed this as completed Feb 18, 2019

[PRE REVIEW]: getTBinR: an R package for accessing and summarising the World Health Organisation Tuberculosis data #1219

[PRE REVIEW]: getTBinR: an R package for accessing and summarising the World Health Organisation Tuberculosis data #1219

Comments

whedon commented Jan 29, 2019 • edited Loading

whedon commented Jan 29, 2019

whedon commented Jan 29, 2019

whedon commented Jan 29, 2019

danielskatz commented Jan 29, 2019

seabbs commented Jan 30, 2019

danielskatz commented Jan 30, 2019

danielskatz commented Jan 30, 2019

whedon commented Jan 30, 2019

whedon commented Jan 30, 2019

seabbs commented Jan 30, 2019

danielskatz commented Jan 30, 2019

seabbs commented Jan 30, 2019

whedon commented Jan 30, 2019

danielskatz commented Jan 30, 2019

whedon commented Jan 30, 2019

danielskatz commented Jan 30, 2019

trallard commented Jan 30, 2019

danielskatz commented Jan 30, 2019

whedon commented Jan 30, 2019

seabbs commented Feb 11, 2019

trallard commented Feb 11, 2019

trallard commented Feb 11, 2019

whedon commented Feb 11, 2019

seabbs commented Feb 11, 2019

seabbs commented Feb 15, 2019

trallard commented Feb 16, 2019

trallard commented Feb 16, 2019

rrrlw commented Feb 16, 2019

trallard commented Feb 18, 2019

trallard commented Feb 18, 2019

strengejacke commented Feb 18, 2019

arfon commented Feb 18, 2019

trallard commented Feb 18, 2019

whedon commented Feb 18, 2019

trallard commented Feb 18, 2019

whedon commented Feb 18, 2019

trallard commented Feb 18, 2019

whedon commented Feb 18, 2019

trallard commented Feb 18, 2019

whedon commented Jan 29, 2019 •

edited

Loading