[PRE REVIEW]: tidyhydat: Extract and Tidy Canadian Hydrometric Data

[whedon]

Submitting author: @boshek (Samuel Albers)
Repository: https://github.com/ropensci/tidyhydat
Version: 0.3.0
Editor: @arfon
Reviewer: @arfon

Author instructions

Thanks for submitting your paper to JOSS @boshek. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@boshek if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #509 with the following error: 

 /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon.rb:106:in `[]': no implicit conversion of String into Integer (TypeError)
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon.rb:106:in `block in parse_affiliations'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon.rb:105:in `each'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon.rb:105:in `parse_affiliations'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon.rb:92:in `parse_authors'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon.rb:76:in `initialize'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon/processor.rb:26:in `new'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/lib/whedon/processor.rb:26:in `set_paper'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/bin/whedon:37:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-453fa9fb981d/bin/whedon:99:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

[arfon]

@openjournals/ropensci - has this package already on-boarded? If so, could you share the thread please?

[arfon]

Scrub that. I found it myself :-) ropensci/software-review#152

[arfon]

@boshek - please merge this PR so we can proceed ropensci/tidyhydat#69

[boshek]

@arfon Merged. Thanks!

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #509 with the following error: 

   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    16  100    16    0     0     39      0 --:--:-- --:--:-- --:--:--    39
Error producing PDF.
! LaTeX Error: File `fancyvrb.sty' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: sty)

Enter file name: 
! Emergency stop.
<read *> 
         
l.153 \newcommand

Looks like we failed to compile the PDF

[arfon]

@whedon assign @arfon as editor

[whedon]

OK, the editor is @arfon

[arfon]

@whedon assign @arfon as reviewer

[whedon]

OK, the reviewer is @arfon

[arfon]

@whedon start review magic-word=bananas

[whedon]

OK, I've started the review over in #511. Feel free to close this issue now!