[PRE REVIEW]: py-opc: operate the Alphasense OPC-N2 from a raspberry pi or other popular microcontrollers/microcomputers #540

whedon · 2018-01-19T14:40:13Z

Submitting author: @dhhagan (David Henry Hagan)
Repository: https://github.com/dhhagan/py-opc
Version: 1.4.1
Editor: @Kevin-Mattheus-Moerman
Reviewers: @tshu

Author instructions

Thanks for submitting your paper to JOSS @dhhagan. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@dhhagan if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

The text was updated successfully, but these errors were encountered:

whedon · 2018-01-19T14:40:16Z

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

whedon · 2018-01-19T14:40:16Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-01-19T14:40:18Z

PDF failed to compile for issue #540 with the following error: 

 /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse': (tmp/540/paper/paper.md): mapping values are not allowed in this context at line 2 column 7 (Psych::SyntaxError)
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse_stream'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:327:in `parse'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:254:in `load'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:475:in `block in load_file'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `open'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `load_file'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-8307502c3aee/lib/whedon.rb:73:in `initialize'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-8307502c3aee/lib/whedon/processor.rb:26:in `new'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-8307502c3aee/lib/whedon/processor.rb:26:in `set_paper'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-8307502c3aee/bin/whedon:37:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-8307502c3aee/bin/whedon:99:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

arfon · 2018-01-19T14:42:50Z

👋 @dhhagan - thanks for your submission to JOSS. It looks like the paper.md YAML header is a little off - this PR should fix it: dhhagan/py-opc#54

From a quick inspection of this submission it's not entirely obvious that it meets our submission criteria. In particular, this item:

Your software should have an obvious research application

Could you confirm here that there is a research application for this software (and explain what that application is)? The section 'what should my paper contain' has some guidance for the sort of content we're looking to be present in the paper.md.

Many thanks!

dhhagan · 2018-01-19T16:26:44Z

Hey @arfon , thanks for the PR (now merged). The research purpose is that it allows researchers to operate the particle counter from any microcontroller, rather than a PC, and is used by many research organizations (EPA, UNEP, MIT, Leeds, etc) to do aerosol research. Maybe a bit more information is given in a pre-submission inquiry I posted last month (openjournals/joss#362).

Let me know if this doesn't fit and I can withdraw.

arfon · 2018-01-20T14:16:03Z

@whedon generate pdf

whedon · 2018-01-20T14:16:05Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-01-20T14:16:22Z

https://github.com/openjournals/joss-papers/blob/joss.00540/joss.00540/10.21105.joss.00540.pdf

arfon · 2018-01-20T14:23:40Z

Hey @arfon , thanks for the PR (now merged). The research purpose is that it allows researchers to operate the particle counter from any microcontroller, rather than a PC, and is used by many research organizations (EPA, UNEP, MIT, Leeds, etc) to do aerosol research. Maybe a bit more information is given in a pre-submission inquiry I posted last month (openjournals/joss#362).

Thanks @dhhagan - I'd forgotten that you'd already enquired. We should be able to proceed here.

While we wait for an editor to volunteer (and then find a reviewer) would you mind fleshing out your paper with a little more detail? Our goal is to have short papers that are understandable by a non-specialist audience. Right now I don't think this paper is quite there.

dhhagan · 2018-01-24T16:20:21Z

Okay. I gave a rewrite a stab. I read a bunch of the accepted papers and tried to model it based on those, so hopefully it is okay now.

Kevin-Mattheus-Moerman · 2018-01-26T02:50:33Z

@whedon generate pdf

whedon · 2018-01-26T02:50:36Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-01-26T02:50:50Z

https://github.com/openjournals/joss-papers/blob/joss.00540/joss.00540/10.21105.joss.00540.pdf

Kevin-Mattheus-Moerman · 2018-01-26T03:00:50Z

👋 @rajeshxsankaran @jared711 @skgrange would you be interested in reviewing this project for the Journal of Open Source Software, the review process focuses largely on the software and a short paper. Let me know if you are available to help so I can open a review issue for this submission.

Kevin-Mattheus-Moerman · 2018-01-26T13:38:33Z

@whedon assign @Kevin-Mattheus-Moerman as editor

whedon · 2018-01-26T13:38:36Z

OK, the editor is @Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman · 2018-01-26T13:43:14Z

@dhhagan thanks for submitting this paper to JOSS. I've started looking for reviewers. If you could suggest suitable reviewers that would be very helpful. Also your work appears to rely on hardware. Will reviewers require this hardware for review? Can some aspects of the code be reviewed without the hardware?

dhhagan · 2018-01-26T14:24:21Z

Hey @Kevin-Mattheus-Moerman: it does rely on hardware - I guess it depends on exactly what the review entails, but it would probably work better with the hardware. I suppose, depending on where the reviewers are located, I could lend a unit for review? What has been done in the past with code that relies on hardware?

Kevin-Mattheus-Moerman · 2018-02-25T14:24:59Z

@amjaeger17 could you help review this please if @dhhagan drops off the device at the Media Lab?

amjaeger17 · 2018-03-01T21:40:17Z

@Kevin-Mattheus-Moerman I can look at this next week if you have not found anyone else yet.

Kevin-Mattheus-Moerman · 2018-03-01T21:56:35Z

@dhhagan could you drop off the device at the MIT Media Lab E14-274G (my office)? I'll then pass it on to @amjaeger17 who can help with review.

dhhagan · 2018-03-01T22:06:07Z

Yup. Absolutely. Do you need a Pi as well?

On Thu, Mar 1, 2018 at 4:56 PM Kevin Mattheus Moerman < ***@***.***> wrote: @dhhagan <https://github.com/dhhagan> could you drop off the device at the MIT Media Lab E14-274G (my office)? I'll then pass it on to @amjaeger17 <https://github.com/amjaeger17> who can help with review. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#540 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEKwSGWv_soTduHh18v4bb9Mk6Z2YvKLks5taG6UgaJpZM4RkkOf> .

-- Regards, David H Hagan PhD Candidate | Atmospheric Chemistry & Physics Department of Civil & Environmental Engineering Massachusetts Institute of Technology Cambridge, MA 02139 707.227.6695 | dhagan@mit.edu | https://www.davidhagan.me

Kevin-Mattheus-Moerman · 2018-03-01T22:38:02Z

We should have lots of pi's but bring yours if you think it is different.

dhhagan · 2018-03-03T23:49:25Z

Perfect. @Kevin-Mattheus-Moerman I'll drop it off Monday mid-morning.

Kevin-Mattheus-Moerman · 2018-03-27T16:21:02Z

@amjaeger17 Could you please give us an estimated timeline for your review to be completed? Thanks

dhhagan · 2018-04-10T13:46:01Z

Hey @Kevin-Mattheus-Moerman Anything I can do to speed this along?

dhhagan · 2018-05-07T12:15:43Z

Hey @Kevin-Mattheus-Moerman I dropped off the device with you, right? Could I come and grab it sometime this week - it needs to go out into the field soon. Thanks!

Kevin-Mattheus-Moerman · 2018-05-07T13:11:03Z

Yes you can. Does Friday work?

arfon · 2018-06-15T19:50:49Z

👋 how are we doing here?

Kevin-Mattheus-Moerman · 2018-06-15T20:33:41Z

The device is still here at the MIT media lab. My colleague @amjaeger17 can unfortunately no longer do this review. I will ask another colleague to take a look but if he cannot then perhaps we are at a dead end for now. Apologies for the delay this has caused with this submission.

Kevin-Mattheus-Moerman · 2018-06-18T18:49:18Z

@whedon assign @tshu as reviewer

whedon · 2018-06-18T18:49:21Z

OK, the reviewer is @tshu

Kevin-Mattheus-Moerman · 2018-06-18T18:50:13Z

@whedon start review magic-word=bananas

whedon · 2018-06-18T18:50:18Z

OK, I've started the review over in #782. Feel free to close this issue now!

whedon added the pre-review label Jan 19, 2018

whedon added Python TeX labels Jan 19, 2018

whedon assigned Kevin-Mattheus-Moerman Jan 26, 2018

whedon unassigned Kevin-Mattheus-Moerman Jun 18, 2018

whedon assigned Kevin-Mattheus-Moerman Jun 18, 2018

Kevin-Mattheus-Moerman closed this as completed Jun 18, 2018

pdebuyl mentioned this issue Jul 28, 2018

JOSS pre-submission enquiry openjournals/joss#362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PRE REVIEW]: py-opc: operate the Alphasense OPC-N2 from a raspberry pi or other popular microcontrollers/microcomputers #540

[PRE REVIEW]: py-opc: operate the Alphasense OPC-N2 from a raspberry pi or other popular microcontrollers/microcomputers #540

whedon commented Jan 19, 2018 •

edited

Loading

whedon commented Jan 19, 2018

whedon commented Jan 19, 2018

whedon commented Jan 19, 2018

arfon commented Jan 19, 2018

dhhagan commented Jan 19, 2018

arfon commented Jan 20, 2018

whedon commented Jan 20, 2018

whedon commented Jan 20, 2018

arfon commented Jan 20, 2018

dhhagan commented Jan 24, 2018

Kevin-Mattheus-Moerman commented Jan 26, 2018

whedon commented Jan 26, 2018

whedon commented Jan 26, 2018

Kevin-Mattheus-Moerman commented Jan 26, 2018 •

edited

Loading

Kevin-Mattheus-Moerman commented Jan 26, 2018

whedon commented Jan 26, 2018

Kevin-Mattheus-Moerman commented Jan 26, 2018

dhhagan commented Jan 26, 2018

Kevin-Mattheus-Moerman commented Feb 25, 2018

amjaeger17 commented Mar 1, 2018

Kevin-Mattheus-Moerman commented Mar 1, 2018

dhhagan commented Mar 1, 2018 via email

Kevin-Mattheus-Moerman commented Mar 1, 2018

dhhagan commented Mar 3, 2018

Kevin-Mattheus-Moerman commented Mar 27, 2018

dhhagan commented Apr 10, 2018

dhhagan commented May 7, 2018

Kevin-Mattheus-Moerman commented May 7, 2018

arfon commented Jun 15, 2018

Kevin-Mattheus-Moerman commented Jun 15, 2018 •

edited

Loading

Kevin-Mattheus-Moerman commented Jun 18, 2018

whedon commented Jun 18, 2018

Kevin-Mattheus-Moerman commented Jun 18, 2018

whedon commented Jun 18, 2018

[PRE REVIEW]: py-opc: operate the Alphasense OPC-N2 from a raspberry pi or other popular microcontrollers/microcomputers #540

[PRE REVIEW]: py-opc: operate the Alphasense OPC-N2 from a raspberry pi or other popular microcontrollers/microcomputers #540

Comments

whedon commented Jan 19, 2018 • edited Loading

whedon commented Jan 19, 2018

whedon commented Jan 19, 2018

whedon commented Jan 19, 2018

arfon commented Jan 19, 2018

dhhagan commented Jan 19, 2018

arfon commented Jan 20, 2018

whedon commented Jan 20, 2018

whedon commented Jan 20, 2018

arfon commented Jan 20, 2018

dhhagan commented Jan 24, 2018

Kevin-Mattheus-Moerman commented Jan 26, 2018

whedon commented Jan 26, 2018

whedon commented Jan 26, 2018

Kevin-Mattheus-Moerman commented Jan 26, 2018 • edited Loading

Kevin-Mattheus-Moerman commented Jan 26, 2018

whedon commented Jan 26, 2018

Kevin-Mattheus-Moerman commented Jan 26, 2018

dhhagan commented Jan 26, 2018

Kevin-Mattheus-Moerman commented Feb 25, 2018

amjaeger17 commented Mar 1, 2018

Kevin-Mattheus-Moerman commented Mar 1, 2018

dhhagan commented Mar 1, 2018 via email

Kevin-Mattheus-Moerman commented Mar 1, 2018

dhhagan commented Mar 3, 2018

Kevin-Mattheus-Moerman commented Mar 27, 2018

dhhagan commented Apr 10, 2018

dhhagan commented May 7, 2018

Kevin-Mattheus-Moerman commented May 7, 2018

arfon commented Jun 15, 2018

Kevin-Mattheus-Moerman commented Jun 15, 2018 • edited Loading

Kevin-Mattheus-Moerman commented Jun 18, 2018

whedon commented Jun 18, 2018

Kevin-Mattheus-Moerman commented Jun 18, 2018

whedon commented Jun 18, 2018

whedon commented Jan 19, 2018 •

edited

Loading

Kevin-Mattheus-Moerman commented Jan 26, 2018 •

edited

Loading

Kevin-Mattheus-Moerman commented Jun 15, 2018 •

edited

Loading