Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: open-mastr: A Python Package to Download and Process the German Energy Registry Marktstammdatenregister #6199

Closed
editorialbot opened this issue Jan 10, 2024 · 39 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 10, 2024

Submitting author: @FlorianK13 (Florian Kotthoff)
Repository: https://github.com/OpenEnergyPlatform/open-MaStR
Branch with paper.md (empty if default branch): feature-462-paper-joss
Version: v0.14.0
Editor: @ppxasjsm
Reviewers: @rafmudaf, @cpschau
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/dc0d33e7dc74f7233e15a7b6fe0c7a3e"><img src="https://joss.theoj.org/papers/dc0d33e7dc74f7233e15a7b6fe0c7a3e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/dc0d33e7dc74f7233e15a7b6fe0c7a3e/status.svg)](https://joss.theoj.org/papers/dc0d33e7dc74f7233e15a7b6fe0c7a3e)

Author instructions

Thanks for submitting your paper to JOSS @FlorianK13. Currently, there isn't a JOSS editor assigned to your paper.

@FlorianK13 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Jan 10, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=2.56 s (44.9 files/s, 699051.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             8              4              0          22321
Python                          45           1546           2018           6900
XML                              1              0              1           1927
Markdown                        19            446              0           1682
Jupyter Notebook                11              0        1746837           1664
SQL                             14            474            668           1591
SVG                              2             59              0           1050
YAML                            11             32              8            293
reStructuredText                 2             98            106             84
TeX                              1              7              0             75
CSS                              1              1              0              6
-------------------------------------------------------------------------------
SUM:                           115           2667        1749638          37593
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1088

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00884 is OK
- 10.5281/zenodo.5677623 is OK
- 10.5281/zenodo.7387843 is OK

MISSING DOIs

- 10.1016/j.apenergy.2018.11.097 may be a valid DOI for title: Open Power System Data–Frictionless data for electricity system modelling

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

elmada: Dynamic electricity carbon emission factors and prices for Europe
Submitting author: @mfleschutz
Handling editor: @fraukewiese (Active)
Reviewers: @nmstreethran, @olejandro
Similarity score: 0.8108

drms: A Python package for accessing HMI and AIA data
Submitting author: @kbg
Handling editor: @xuanxu (Active)
Reviewers: @mgckind, @aureliocarnero
Similarity score: 0.8025

FASMA 2.0: A Python package for stellar parameters and chemical abundances
Submitting author: @MariaTsantaki
Handling editor: @xuanxu (Active)
Reviewers: @warrickball, @ipelupessy
Similarity score: 0.7964

CESAR-P: A dynamic urban building energy simulation tool
Submitting author: @kristina-o
Handling editor: @timtroendle (Active)
Reviewers: @olejandro, @noah80, @jasondegraw
Similarity score: 0.7956

MiSTree: a Python package for constructing and analysing Minimum Spanning Trees
Submitting author: @knaidoo29
Handling editor: @xuanxu (Active)
Reviewers: @melissawm, @zonca
Similarity score: 0.7944

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@FlorianK13
Copy link

By searching for "energy" and "data" in the the list of people that have already agreed to review, I found the following potential reviewers:

@kyleniemeyer
Copy link

Thanks @FlorianK13, those suggestions will be helpful.

Unfortunately, we don't have any editors available to handle your submission right now, so I need to put this on our waitlist until someone can edit it.

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 10, 2024
@ppxasjsm
Copy link

@kyleniemeyer I think I can edit this.

@kyleniemeyer
Copy link

@editorialbot assign @ppxasjsm as editor

Thanks @ppxasjsm!

@editorialbot
Copy link
Collaborator Author

Assigned! @ppxasjsm is now the editor

@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Feb 1, 2024
@ppxasjsm
Copy link

ppxasjsm commented Feb 2, 2024

Hi @FlorianK13 I'll be your editor for this submission. If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission. Also I noticed there is a missing DOI in the paper. Could you please try and add this and run the check references option with editorialbot to make sure no more references are missing? If you have any questions at any point please get in touch (ideally using @).

@FlorianK13
Copy link

Hi @ppxasjsm, thanks for being the editor. Regarding potential reviewers, I created this list a few comments above in this issue. Additionally, I'll check the missing DOI soon and add it.

By searching for "energy" and "data" in the the list of people that have already agreed to review, I found the following potential reviewers:

* [adamrjensen](https://github.com/adamrjensen)

* [nick-gorman](https://github.com/nick-gorman)

* [Himscipy](https://github.com/Himscipy)

* [sevberg](https://github.com/sevberg)

* [jordanperr](https://github.com/jordanperr)

@ppxasjsm
Copy link

ppxasjsm commented Feb 3, 2024

Thank you @FlorianK13 I had somehow missed this. I'll start asking potential reviewers.

@ppxasjsm
Copy link

ppxasjsm commented Feb 3, 2024

Hi @AdamRJensen, would you be available to review this JOSS submission?

@ppxasjsm
Copy link

ppxasjsm commented Feb 3, 2024

Hi @nick-gorman, any chance you would be available to review this JOSS submission?

@AdamRJensen
Copy link

Hi @AdamRJensen, would you be available to review this JOSS submission?

I just started as a JOSS editor so Ill spend my JOSS time in that role in the upcoming time

@ppxasjsm
Copy link

ppxasjsm commented Feb 3, 2024

@AdamRJensen Oh nice one, sorry I had clearly missed that part!

@ppxasjsm
Copy link

ppxasjsm commented Feb 3, 2024

Hi @Himscipy, is there any chance you'd be available to review this submission?

@FlorianK13
Copy link

@ppxasjsm Should I search for more potential reviewers in the list?

@Himscipy
Copy link

Hi @ppxasjsm and @FlorianK13, 👋🏼
Thank you for considering me for the review. Unfortunately, I won't be able to review this promptly due to some previous commitments.

@ppxasjsm
Copy link

Hi @rafmudaf, thank you for reviewing this submission.

@rafmudaf
Copy link

rafmudaf commented Mar 7, 2024

Hi @ppxasjsm do we need to do the whedon or editorialbot request to create a new issue for me to complete the review? In getting started here, I went to an old review I completed to see the format, and I noticed it was created automatically by this and this command.

@kyleniemeyer
Copy link

@editorialbot add @rafmudaf as reviewer

@editorialbot
Copy link
Collaborator Author

@rafmudaf added to the reviewers list!

@kyleniemeyer
Copy link

Hi @rafmudaf, after finding a second reviewer, @ppxasjsm will create a separate review issue where you'll add your review checklist and comments. Feel free to begin in the meantime, though!

@rafmudaf
Copy link

Ah great, thanks @kyleniemeyer

@FlorianK13
Copy link

Hi @ppxasjsm
We fixed some bugs at open-mastr and released a new version. I now wanted to check the current status of finding Reviewers. I also looked into the list of possible Reviewers and found a few more:

Lorenzo Schena
Lokendra Singh Rathore
@kramea

@FlorianK13
Copy link

Hi @kyleniemeyer, do you know something about the current state of the search for reviewers?

@ppxasjsm
Copy link

ppxasjsm commented May 9, 2024

Hi @FlorianK13, I am really sorry for having dropped this. I ran in to issues securing reviewers and then it dropped of my radar due to a super busy semester. I am back on track now.

@ppxasjsm
Copy link

ppxasjsm commented May 9, 2024

Hi @LSRathore, I was wondering if you might be available to review this JOSS submission?

@LSRathore
Copy link

@ppxasjsm, won't be able to review this time, sorry.

@ppxasjsm
Copy link

Hi @kramea, I was wondering if you were at all available to review this JOSS submission?

@ppxasjsm
Copy link

Hi @FHell, Is there any chance you could review this JOSS submission?

@FHell
Copy link

FHell commented May 13, 2024

@ppxasjsm Not my area of expertise, sorry. Sent you some suggestions.

@ppxasjsm
Copy link

@editorialbot add @cpschau as reviewer

@editorialbot
Copy link
Collaborator Author

@cpschau added to the reviewers list!

@ppxasjsm
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6758.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants