-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: cppdlr: Imaginary time calculations using the discrete Lehmann representation #6297
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@editorialbot generate preprint |
📄 Preprint file created: Find it here in the Artifacts list 📄 |
@editorialbot generate pdf |
@editorialbot generate preprint |
📄 Preprint file created: Find it here in the Artifacts list 📄 |
I'm sorry that this review is taking so long. I've found it extremely difficult to find an expert reviewer - most people seem quite reticent to express an opinion given the standing of the authors in the field. I will now take the unusual step of reviewing it myself, while continuing to search for an expert to weigh in with an external view of the physics. |
@editorialbot remove @Neutrino155 from reviewers |
@Neutrino155 is not in the reviewers list |
@editorialbot add @jarvist to reviewers |
@jarvist added to the reviewers list! |
Review checklist for @jarvistConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot assign me as editor |
Assigned! @kyleniemeyer is now the editor |
@editorialbot add @stevenrbrandt as reviewer Steve Brandt has agreed to provide another review within the next few weeks or so. Thanks! |
@stevenrbrandt added to the reviewers list! |
Done! version is now 1.2.0 |
@editorialbot set 10.5281/zenodo.13177024 as archive |
Done! archive is now 10.5281/zenodo.13177024 |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5726, then you can now move forward with accepting the submission by compiling again with the command |
Thanks @jasonkaye - please review the paper proof, and then I will accept. |
@editorialbot generate pdf |
@kyleniemeyer My apologies, but we needed to make a couple of small edits to affiliations and references, which we have pushed to our repo---see also the generated pdf above. If you could regenerate the final proof with these changes, I can take a final read over and confirm. Thanks. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5730, then you can now move forward with accepting the submission by compiling again with the command |
@kyleniemeyer I have reviewed the final proof and everything looks good. Thanks. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @jasonkaye on your article's publication in JOSS! Thanks for your patience throughout this process. Many thanks to @jarvist and @stevenrbrandt for reviewing this submission. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Great, thanks @kyleniemeyer for your help. |
Submitting author: @jasonkaye (Jason Kaye)
Repository: https://github.com/flatironinstitute/cppdlr/
Branch with paper.md (empty if default branch): joss
Version: 1.2.0
Editor: @kyleniemeyer
Reviewers: @jarvist, @stevenrbrandt
Archive: 10.5281/zenodo.13177024
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jarvist and @stevenrbrandt, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kyleniemeyer know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jarvist
📝 Checklist for @stevenrbrandt
The text was updated successfully, but these errors were encountered: