-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: MIRP: A Python package for standardised radiomics #6413
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
👋 Hi @surajpaib, @Matthew-Jennings, @drcandacemakedamoore, @theanega, and thank you again for agreeing to review this submission for MIRP ! The review will take place in this issue, and you can generate your individual reviewer checklists by asking editorialbot directly with In working through the checklist, you're likely to have specific feedback on MIRP. Whenever possible, please open relevant issues on the software repository (and cross-link them with this issue) rather than discussing them here. This helps to make sure that feedback is translated into actionable items to improve the software ! If you aren't sure how to get started, please see the Reviewing for JOSS guide -- and, of course, feel free to ping me with any questions ! |
Review checklist for @surajpaibConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @drcandacemakedamooreConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @Matthew-JenningsConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @theanegaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
@alexzwanenburg Can you please clarify if Sebastian Starke and Steffan Lock are the same person. I do not see any code contributions from a Steffan Lock. This may be fine if he helped make the package, but please clarify. Or maybe Steffan Leger as mentioned in the thank you at the bottom is the same as Steffan Lock? |
@drcandacemakedamoore Steffen Löck is my professor and advised on the paper and the package. Stefan Leger contributed to early in-house versions of MIRP, prior to moving GitHub. Sebastian Starke also made minor contributions to an earlier version of MIRP. |
@alexzwanenburg preferably module names should be all lower case (and super-best is single word or if no other choice with underscore). I notice you have modules that are camelcase. Different file systems have different case conventions. The real point is that it could be possible to import these modules in two different ways then cause problems on different files systems where case conventions are different. I will get to more substantial issues soon, but this already pops out for my eyes, before I even started the real review. But since I'm on superficial issues right now, some badges would not hurt (it's nice to have the pypi version badge and also Anaconda if you released it there, and I can't tell at first glance here.) |
@alexzwanenburg on a less superficial issue, I note there is no developer's documentation. Many people may want to tinker with what you have done, and hopefully even contribute to the package. I am looking for documentation somewhere that tells people how to run the testing, so they can test new stuff before sending it. I am also looking for this, because it is not clear if you have any automated testing that runs in CI (did I miss it?) so instead of figuring out how to run it from there I would need instructions to run your tests properly . Update: I see from my Windows machine it is |
Thank you, @drcandacemakedamoore ! If you could please open subsequent review comments as issues on the MIRP repository, this will help to make sure there is sufficient space for follow-up discussion and that action items are trackable across reviewers. I know that @alexzwanenburg has started to respond in-thread, but we'll generally ask to keep only high-level discussions in the general review thread and re-direct all other comments to the project issue tracker. If you have any other questions, of course, please don't hesitate to ask. |
👋 Hi everyone, happy Monday ! I just wanted to check-in on the status of this review and make sure that there weren't any current blockers in working through the reviewer checklists. I did notice that @drcandacemakedamoore has opened oncoray/mirp#66, oncoray/mirp#67, and oncoray/mirp#68 -- thank you ! I'm cross-linking them here, so they're easier for myself (and other reviewers) to track. |
Hello! Thank you very much for the invitation to review this paper. I will finalize the review later this week (only the "functionality" section is missing). For now, I've left my comments on issue #69 . |
👋 Hi everyone ! Thank you for your comments on MIRP to date ! I just wanted to note that we have now passed the four week review window. If you could please work on finalizing your initial reviews as soon as possible, I would appreciate it. Once you have finalized your initial reviews, you can let me know by responding directly in this thread. Of course, if you have any questions or blockers, please don't hesitate to let me know ! 🙏 @surajpaib @Matthew-Jennings @drcandacemakedamoore @theanega |
@editorialbot generate pdf |
@editorialbot check references |
|
Thank you, @alexzwanenburg ! I'm now happy to recommend mirp to the EiC team for publication in JOSS ✨🚀 Thank you, too, to @surajpaib, @Matthew-Jennings, @drcandacemakedamoore, and @theanega for your reviews and involvement throughout this process ! JOSS works because of your work 💐 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5580, then you can now move forward with accepting the submission by compiling again with the command |
Aside from an overly wide sentence on page 2 the proof looks fine from my perspective. |
@openjournals/bcm-eics, just re-pinging here in case this notification slipped through ! Thank you 🙏 |
@editorialbot set version as v2.2.4 |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot set v2.2.4 as version |
Done! version is now v2.2.4 |
@alexzwanenburg as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Most seems in order, however the below are some points that require your attention:
|
@editorialbot generate pdf |
I made changed |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on this JOSS publication @alexzwanenburg et al. ! Thanks for editing @emdupre ! And a special thank you to the reviewers: @surajpaib, @Matthew-Jennings, @drcandacemakedamoore, @theanega !! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @alexzwanenburg (Alex Zwanenburg)
Repository: https://github.com/oncoray/mirp
Branch with paper.md (empty if default branch): paper
Version: v2.2.4
Editor: @emdupre
Reviewers: @surajpaib, @Matthew-Jennings, @drcandacemakedamoore, @theanega
Archive: 10.5281/zenodo.12493595
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@surajpaib & @Matthew-Jennings & @drcandacemakedamoore & @theanega, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @surajpaib
📝 Checklist for @Matthew-Jennings
📝 Checklist for @drcandacemakedamoore
📝 Checklist for @theanega
The text was updated successfully, but these errors were encountered: