Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: aPhyloGeo: a multi-platform Python package for analyzing phylogenetic trees with climatic parameters #6579

Open
editorialbot opened this issue Apr 3, 2024 · 174 comments
Assignees
Labels
Perl Python review Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 3, 2024

Submitting author: @TahiriNadia (Nadia Tahiri)
Repository: https://github.com/tahiri-lab/aPhyloGeo
Branch with paper.md (empty if default branch): joss-journal
Version: v1.0.0
Editor: @arfon
Reviewers: @annazhukova, @mmore500, @theosanderson
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6ae3cefa29ca05aa1119994549c877cb"><img src="https://joss.theoj.org/papers/6ae3cefa29ca05aa1119994549c877cb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6ae3cefa29ca05aa1119994549c877cb/status.svg)](https://joss.theoj.org/papers/6ae3cefa29ca05aa1119994549c877cb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@annazhukova & @mmore500, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fboehm know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @annazhukova

📝 Checklist for @mmore500

📝 Checklist for @theosanderson

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.25080/majora-212e5952-018 is OK
- 10.2307/2413638 is OK
- 10.25080/gerudo-f2bc6f59-00f is OK
- 10.1093/molbev/msl072 is OK
- 10.1016/0025-5564(81)90043-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (579.0 files/s, 192692.8 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Bourne Again Shell                2            308            722           5096
XML                               6              0              0           4149
Python                            9            491            949           1186
CSV                              12            677              0            811
Perl                              2            290            104            670
Ruby                              1             64             66            375
Markdown                          3            109              0            275
YAML                             10             15             55            205
TOML                              1              8              0             66
TeX                               1              0              0             51
DOS Batch                         2              7              6             28
PowerShell                        1              4            161             11
make                              1              3              0             10
--------------------------------------------------------------------------------
SUM:                             51           1976           2063          12933
--------------------------------------------------------------------------------

Commit count by author:

   209	Nadia Tahiri, PhD
   169	my-linh-luu
    56	Georges Marceau
    54	Nadia Tahiri
    37	slepaget
    30	cetmus
    25	db036
    25	geomarceau
    18	Elie Maalouf
    14	francis.lewis07@gmail.com
    11	Simon Lepage-Trudeau
     9	simlal
     8	Alex
     4	Wanlin Li
     2	Marc-Antoine Bélisle
     2	Mus
     2	Nadia Tahiri, Ph. D
     2	TahiriNadia
     2	jsDesm
     1	KarlP910

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1560

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@fboehm
Copy link

fboehm commented Apr 3, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.25080/majora-212e5952-018 is OK
- 10.2307/2413638 is OK
- 10.25080/gerudo-f2bc6f59-00f is OK
- 10.1093/molbev/msl072 is OK
- 10.1016/0025-5564(81)90043-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@fboehm
Copy link

fboehm commented Apr 3, 2024

@TahiriNadia - we've now started the "review" thread on github, ie, here. Please use this comment thread to ask questions and, once initial reviews are available, to respond to issues that the reviewers raise.

@annazhukova
Copy link

annazhukova commented Apr 4, 2024

Review checklist for @annazhukova

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/tahiri-lab/aPhyloGeo?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@TahiriNadia) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@mmore500
Copy link

mmore500 commented Apr 4, 2024

Review checklist for @mmore500

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/tahiri-lab/aPhyloGeo?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@TahiriNadia) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [-] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • [-] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • [-] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • [-] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • [-] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@fboehm
Copy link

fboehm commented Apr 20, 2024

@mmore500 - how is the review going? Do you have any questions?

@mmore500
Copy link

Thanks for checking in. No issues so far! I have some time set aside shortly to sit down and complete my review.

@fboehm
Copy link

fboehm commented Apr 22, 2024

Thanks for checking in. No issues so far! I have some time set aside shortly to sit down and complete my review.

This sounds great, @mmore500 ! Please let me know if any questions arise. Thank you again!

@fboehm
Copy link

fboehm commented Apr 22, 2024

@annazhukova - how is the review going? do you have any questions yet?

@mmore500
Copy link

mmore500 commented Apr 22, 2024

Some comments on the manuscript. Planning to follow up on the software content shortly.

Introduction

There is a grammar issue in “between a genetic of species and its habitat during the reconstruction”

Statement of Need

Address in more specific terms what specific scientific question(s) an be addressed through these analyses.

State of the Field

  • by topological similarity, do you mean topological agreement?
  • Consider phrasing in terms of first person (we) when discussing your own group

figure

  • in addition to the legend, it may make sense to additionally directly label the color background boxes (in addition to the symbol glyph labels, toes are nice!!)
  • where possible, increase the font size, most of the figure can only be read by zooming way in.
  • why are the biopython and python logos in the corner? if it’s meant as an acknowledgement, I think that would be better suited to other parts of the paper)
  • what is a climate tree? This hasn’t yet been explicitly defined

Pipeline:

  • Can you clarify this sentence: “…, forming the basis from which users obtain output data with essential calculations.” What data nd what calculations?
  • In discussion of the figure, it’s unclear what “refer to the YAML file” means —— that hasn’t yet been introduced
  • rephrase “optimal” as “optimized”

Multiprocessing:

What windows are you referring to?

Dependencies:

Citations to the software would be appropriate.

Conclusion:

  • What specific problems or circumstances will the new methods allow to be tackled?
  • “high standards in software development” —> “best practices in software development”
  • Could the closing two sentences of the conclusion be made more specific and concrete? As written, they could describe a large number of software projects.

Overall:

a specific application example or case study would greatly benefit the clarity of the manuscript

@annazhukova
Copy link

I have filled in my checklist, and here are a few comments:

  • Contribution and authorship: Has the submitting author (@TahiriNadia) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

I have not ticked this iteam as looking at the contributors page I saw that the user my-linh-luu seemed to have contributed substantially to the software but does not seem to be on the authors’ list

  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

From what I understood from the guidlines, the software needs to be already quite established (cited, used) which does not yet seem to be the case here.

Some factors that may be considered by editors and reviewers when judging effort include:
Age of software (is this a well-established software project) / length of commit history

I saw that the first tag was in June 2022, so one would expect a quite established software with quite some usages

Number of commits:

I have counted about 600 on the contributors page

Number of authors:

3 (on the paper, more on github)

Total lines of code (LOC). Submissions under 1000 LOC will usually be flagged, those under 300 LOC will be desk rejected.

I have assessed the LOC with wc -l *.py command on the aphylogeo folder: 2152

Whether the software has already been cited in academic papers.

According to google-scholar the only citation is a self-citation

Whether the software is sufficiently useful that it is likely to be cited by your peer group.

I think that a clear example of an analysis pipeline with the software would highly increase the chances of future citations (as people would know how to use the software for their data).

Functionality

  • [] Installation: Does installation proceed as outlined in the documentation?

See this issue

  • Functionality: Have the functional claims of the software been confirmed?

I haven't managed to install it (see above)

  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

I haven't managed to install it (see above)

Documentation

  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).

See issue

  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?

See issue

  • [ x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

There are guidlines but they could be better illustrated: see issue

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?

From what I understood at first the goal of the software is to allow to analyse the correlation between the climate and species evolution. Though reading further and especially looking at the figure, it seems to me that the goal might be to select gene regions that have the most correlation (?)
Overall I think a use case, an example of a data analysis with aPhyloGeo in the article (and the corresponding data and code available and described in GitHub) would highly facilitate understanding the goals.

  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?

There is the corresponding section, but it reads to me a bit too general. A more concrete example would help here too.

  • State of the field: Do the authors describe how this software compares to other commonly-used packages?

The authors only mention their own previous work in this section. I would expect here seeing what can be done with other packages, for instance used in classical phylogeography: Ancestral Character Reconstruction for geographic and or climate characters, GLM with climate as a factor etc.

  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Adding more information to the State of the field section would add more references too

@fboehm
Copy link

fboehm commented Apr 30, 2024

@TahiriNadia - it looks like @mmore500 and @annazhukova have offered comments on the submission. Do you have any questions on how to proceed?

@fboehm
Copy link

fboehm commented Apr 30, 2024

@mmore500 - when it's possible, please place check marks in your checklist above. It seems to be empty right now. Thanks again!

@fboehm
Copy link

fboehm commented Sep 10, 2024

@TahiriNadia - do you have any questions about the remaining tasks?

Please let me know. Thanks again!

@TahiriNadia
Copy link

Sorry for the delay and for dropping off this thread. I have now completed my checklist. My primary concern continues to be that I don't feel that I've seen evidence that this tool is able to discover scientifically meaningful results. (I'm not asserting that it cannot, just that I haven't seen evidence). I set out these concerns in tahiri-lab/aPhyloGeo#55 .

No problem at all, and thanks for following up! Instead of using the dataset you originally suggested (due to some links being unavailable), we shifted our focus to the dataset from Uhlir et al. (2021) "Adding pieces to the puzzle: insights into diversity and distribution patterns of Cumacea (Crustacea: Peracarida) from the deep North Atlantic to the Arctic Ocean" [1]. Through this analysis, we derived substantial conclusions that demonstrate the scientific relevance and potential of the package. These findings offer compelling evidence of its utility for the research community.

Additionally, we are currently in active communication with the lead author of the Uhlir et al. study to ensure the final validation of our results. You can find further details and examples of our study case in the documentation.

I hope this provides clarity, and I'm happy to engage in further discussion if needed!

[1] Uhlir, C., Schwentner, M., Meland, K., Kongsrud, J. A., Glenner, H., Brandt, A., Thiel, R., Svavarsson, J., Lörz, A.-N., & Brix, S. (2021). Adding pieces to the puzzle: insights into diversity and distribution patterns of Cumacea (Crustacea: Peracarida) from the deep North Atlantic to the Arctic Ocean. PeerJ, 9, e12379.

@TahiriNadia
Copy link

@TahiriNadia - do you have any questions about the remaining tasks?

Please let me know. Thanks again!

@TahiriNadia - do you have any questions about how to address the remaining open issues?

Thank you, @fboehm. I’ve completed the revisions for the second tutorial as recommended in the review and am now addressing licensing and making a few final adjustments. I’ll present a new solution ASAP.

@TahiriNadia
Copy link

@TahiriNadia - do you have any questions about the remaining tasks?

Please let me know. Thanks again!

Thank you, @fboehm. I will continue to work on it.

@fboehm
Copy link

fboehm commented Sep 10, 2024

Thank you @TahiriNadia !

I appreciate your continued work on this. I realize that you and your team have many duties, and I hope that I'm not pestering you. I'm hoping to keep communications happening, even in weeks when people might not have time to work on the remaining tasks.

I'm also trying to respect the time and commitments of the reviewers. I appreciate your understanding.

Thanks again!

@TahiriNadia
Copy link

Thank you, @fboehm, for your thoughtful message. We appreciate your understanding, and we’ll continue to keep communication open even during busier weeks. Rest assured, we're working diligently to balance our ongoing responsibilities and will keep moving forward with the remaining tasks.

We’re mindful of the reviewers’ time as well and are committed to maintaining progress. Thanks again for your patience and support!

Thanks again.

@TahiriNadia
Copy link

Dear @fboehm
Since the interns left in July, recruiting students for a small lab focused on phylogeny—a topic not particularly appealing—has proven quite challenging. With ongoing commitments, conferences, two courses, and grant applications, I have now completed all the reviewers' requests comprehensively (covering every detail, including the BIN, tests, tutorial, Sphinx documentation, README, and wiki).
Sincerely,

@arfon
Copy link
Member

arfon commented Nov 1, 2024

@editorialbot assign me as editor

👋 folks, @fboehm has asked me to help out with his submissions so I'm going to take this one over.

@TahiriNadia – from your most recent comment here it seems like you feel like you have accommodated/responded to all of the reviewer feedback at this point?

Reading the thread history, the most meaningful outstanding question seems to be that from @theosanderson here: tahiri-lab/aPhyloGeo#55 . @theosanderson do you feel like your questions/concerns have been adequately addressed?

@editorialbot editorialbot assigned arfon and unassigned fboehm Nov 1, 2024
@editorialbot
Copy link
Collaborator Author

Assigned! @arfon is now the editor

@theosanderson
Copy link

theosanderson commented Nov 1, 2024

Hello,
I am grateful to the authors for their considerable work to respond to the reviewers' comments.

Unfortunately, my initial concerns persist. I was concerned that the approach taken by aPhyloGeo would not yield meaningful results about connections between climatic factors and evolution. I have not yet seen evidence that it can. The authors have provided an analysis of 35 sequences of 500bp of ribosomal RNA from shrimps, and claim that they can identify specific regions of this sequence which correlate with wind-speed and (separately) with oxygen concentration. It seems to me very unlikely that an analysis of 35 sequences would have adequate power to detect statistically meaningful such effects given the number of degrees of freedom (many windows of this sequence, many environmental variables). The authors' other example, of SARS-CoV-2, consists of just five sequences. (These concerns should not really be interpreted as a request for larger analyses: the convincing evidence would come from comparing to data with a known ground-truth relationship between evolution and climatic factors).

@arfon
Copy link
Member

arfon commented Nov 1, 2024

Thanks @theosanderson. If I'm understanding the concern here, the concern is whether this software can be used to generate meaningful scientific results?

Typically we wouldn't try and pass judgement this at JOSS (i.e., we're not looking to validate scientific results here), but if I understand correctly, this software has yet to be used to generate scientific outputs for any peer-reviewed papers @TahiriNadia? I note that in this issue, you point to this analysis https://github.com/tahiri-lab/aPhyloGeo/wiki/Study-case – is it correct to say that this analysis has not been published in a peer reviewed journal yet?

@theosanderson
Copy link

Yes @arfon I think that's largely correct. My concerns relate to the claims that the tool can give insights into the role of climate in affecting evolution rather than into whether it performs the workflow in Fig. 1. I can confirm that it does (appear to) perform the workflow shown in Fig. 1, and if that's sufficient for an editorial decision that's great.

I believe the authors have cited aPhyloGeo in some reviewed conference proceedings.

@arfon
Copy link
Member

arfon commented Nov 6, 2024

Thanks @theosanderson. @TahiriNadia – I'd like to offer you the chance to provide a clear rebuttal here, but based on the review feedback, my current inclination is to reject this submission due to lack of (peer reviewed) evidence that the software is doing something with scientific merit. Please respond with any further information/justifications you have.

@TahiriNadia
Copy link

Thank you, @arfon, for providing the opportunity to elaborate on our work.

Our tool has been rigorously peer-reviewed and published in the SciPy proceedings over three consecutive years (2022, 2023, and most recently a few weeks ago in 2024), demonstrating a commitment to reproducible and scalable phylogenetic and phylogeographic analyses. This progression has consistently showcased improvements and new features that enhance the tool’s ability to address key challenges in host-virus relationships and pathogen evolution, as demonstrated in our recent work on coronavirus and bat host interactions (Li & Tahiri, 2024). Each publication highlights the practical utility and scientific relevance of our tool, addressing issues of data integration and reproducibility that are critical to advancing research in phylogeny.

Moreover, our tool’s pertinence has been further validated through an active collaboration with Uhlir et al. (2021), specifically leveraging their extensive dataset on Cumacea diversity and distribution from the North Atlantic to the Arctic, published in PeerJ. This collaborative validation provided an ecological framework that underscored aPhyloGeo’s flexibility and robustness when applied to complex ecological data, establishing its value beyond viral phylogenies and into broader ecological contexts. Uhlir et al.’s involvement has been instrumental in ensuring the tool’s functionality aligns with both ecological and evolutionary research needs.

In addition to these peer-reviewed outcomes, we are preparing a new manuscript that will present additional applications and validation results in a forthcoming journal submission. This new work will continue to build on our tool’s scientific impact, further solidifying its role as a versatile, scientifically robust resource for the research community.

@TahiriNadia
Copy link

Thanks @theosanderson. If I'm understanding the concern here, the concern is whether this software can be used to generate meaningful scientific results?

Typically we wouldn't try and pass judgement this at JOSS (i.e., we're not looking to validate scientific results here), but if I understand correctly, this software has yet to be used to generate scientific outputs for any peer-reviewed papers @TahiriNadia? I note that in this issue, you point to this analysis https://github.com/tahiri-lab/aPhyloGeo/wiki/Study-case – is it correct to say that this analysis has not been published in a peer reviewed journal yet?

Thanks, @arfon. To clarify, the tool has indeed been validated and used to produce scientific results that have undergone peer review. Recently, our results were accepted in the SciPy proceedings as part of a peer-reviewed conference, where we detailed the scientific insights generated by the tool. Additionally, we have actively collaborated with the Uhlir team, using their ecological datasets to further validate the software’s relevance and applicability.

@TahiriNadia
Copy link

from your most recent comment here it seems like you feel like you have accommodated/responded to all of the reviewer feedback at this point?

@arfon:
Yes, that is correct! We feel we have thoroughly addressed all reviewer feedback and provided the necessary clarifications regarding the peer-reviewed validation and application of our tool.

@TahiriNadia
Copy link

TahiriNadia commented Nov 6, 2024

all the reviewers' requests comprehensively (covering every detail, including the BIN, tests, tutorial, Sphinx documentation, README, and wiki).

All the reviewers' requests have been addressed comprehensively, covering every detail, including the BIN repertory, tests, tutorial, Sphinx documentation, README, and wiki.

@mmore500
Copy link

mmore500 commented Nov 7, 2024

The references provided are very useful, thanks for passing them along.

In (Li & Tahiri, 2024), I do see how distance comparisons between trees (i.e., the bat host phylogenies and coronavirus phylogenies) were applied shed light on co-evolution. Would you be able to clarify the role of biogeography, and more explicitly aPhyloGeo’s concept of climatic trees, in that work?

Could you also clarify the role that the aPhyloGeo code itself in that work? I looked through the workflow files linked at https://github.com/tahiri-lab/aPhyloGeo.sm/, and didn’t see aPhyloGeo used as an import or portions of the aPhyloGeo library code I recognized included directly.

@TahiriNadia
Copy link

TahiriNadia commented Nov 7, 2024

(peer reviewed) evidence

Dear @arfon,

List of peer-reviewed evidence:

1️⃣ Gagnon, J. & Tahiri, N. (2024). Ecological and Spatial Influences on the Genetics of Cumacea (Crustacea: Peracarida) in the Northern North Atlantic. Proceeding in SciPy 2024, Tacoma, WA, USA

2️⃣ Li, W. (2023). New algorithm to assess the environmental influence of Coronavirus through phylogeographic analysis. MSc. these, University of Sherbrooke, QC, Canada.

3️⃣ Li, W. & Tahiri, N. (2024). Host–Virus Cophylogenetic Trajectories: Investigating Molecular Relationships between Coronaviruses and Bat Hosts. Viruses, 16(7), 1133.

4️⃣ Li, W. & Tahiri, N. (2023). aPhyloGeo-Covid: A Web Interface for Reproducible Phylogeographic Analysis of SARS-CoV-2 Variation using Neo4j and Snakemake. Proceeding in SciPy 2023, Auxtin, TX, USA

5️⃣ Koshkarov, A., Li, W., Luu, M. L., & Tahiri, N. (2022). Phylogeography: Analysis of genetic and climatic data of SARS-CoV-2. Proceeding in SciPy 2022, Auxtin, TX, USA

@TahiriNadia
Copy link

The references provided are very useful, thanks for passing them along.

In (Li & Tahiri, 2024), I do see how distance comparisons between trees (i.e., the bat host phylogenies and coronavirus phylogenies) were applied shed light on co-evolution. Would you be able to clarify the role of biogeography, and more explicitly aPhyloGeo’s concept of climatic trees, in that work?

Could you also clarify the role that the aPhyloGeo code itself in that work? I looked through the workflow files linked at https://github.com/tahiri-lab/aPhyloGeo.sm/, and didn’t see aPhyloGeo used as an import or portions of the aPhyloGeo library code I recognized included directly.

Dear @mmore500, Thank you for the insightful question. For our study, we did indeed include the aPhyloGeo package via pipy to support the analyses.

The references you provided offer valuable context, particularly regarding the role of distance comparisons in understanding co-evolution patterns, as seen in (Li & Tahiri, 2024). In that work, biogeography, and more specifically the concept of climatic trees within aPhyloGeo, was essential for mapping phylogenetic relationships against climatic gradients, revealing potential ecological constraints on co-evolutionary dynamics.

Best.

@mmore500
Copy link

mmore500 commented Nov 7, 2024

Apologies if I'm missing something obvious, but could you link me to the lines in https://github.com/tahiri-lab/aPhyloGeo.sm/ where aPhyloGeo is imported and used so I can better understand the role that it played? I cloned a copy of that repository and performed a project search for "aphylogeo" (case insensitive) but wasn't able to locate the parts of the pipeline it was integrated into.

@mmore500
Copy link

mmore500 commented Nov 7, 2024

Looking closely through (Li & Tahiri, 2024), I do see some mentions of the bat populations being sampled from a specific region (China). I did also see a brief note in the discussion that suggests an analogy between vicariance/biogeography and host range:

When contemplating the associations between hosts and parasites, particularly within the scope of our study of CoVs, an analogy can be drawn from vicariance biogeography. In this analogy, the host can be likened to a “region” exploited by the parasite, and host speciation can be seen as analogous to a “vicariance event” [58].

Could you more directly point me to which analyses reported in https://doi.org/10.3390/v16071133 explicitly incorporate climactic or geographic data? I also looked in the supplement at https://www.mdpi.com/article/10.3390/v16071133/s1 but did not immediately see where climactic or geographic data was incorporated into analyses.

@TahiriNadia
Copy link

Looking closely through (Li & Tahiri, 2024), I do see some mentions of the bat populations being sampled from a specific region (China). I did also see a brief note in the discussion that suggests an analogy between vicariance/biogeography and host range:

When contemplating the associations between hosts and parasites, particularly within the scope of our study of CoVs, an analogy can be drawn from vicariance biogeography. In this analogy, the host can be likened to a “region” exploited by the parasite, and host speciation can be seen as analogous to a “vicariance event” [58].

Could you more directly point me to which analyses reported in https://doi.org/10.3390/v16071133 explicitly incorporate climactic or geographic data? I also looked in the supplement at https://www.mdpi.com/article/10.3390/v16071133/s1 but did not immediately see where climactic or geographic data was incorporated into analyses.

Thank you, @mmore500, for your detailed review and questions. In (Li & Tahiri, 2024), the primary focus was indeed on the cophylogenetic patterns between coronaviruses (CoVs) and bats rather than on explicit climatic or geographic variables. The geographic scope—bat samples from China—was contextualized primarily to leverage the region’s diverse bat populations as a rich source of CoV diversity and host-virus interactions. Specific geographic origins of the bat species were referenced through metadata in GenBank and the original studies; however, these were not analyzed with climate data or mapped with explicit spatial models (but indirectly with geographical conditions).

The study does make an analogy to vicariance biogeography in discussing host-parasite relationships, but this analogy serves more as a conceptual framework rather than being operationalized in a climate or geography-based model. The analyses center on genetic data, phylogenetic congruence, geographic, and recombination regions, focusing on the molecular dynamics between hosts and CoVs rather than incorporating climatic variables directly.

If further elaboration on these regional influences is valuable, incorporating spatial or climate-focused data could indeed provide additional context to the observed host-virus associations.

@TahiriNadia
Copy link

Apologies if I'm missing something obvious, but could you link me to the lines in https://github.com/tahiri-lab/aPhyloGeo.sm/ where aPhyloGeo is imported and used so I can better understand the role that it played? I cloned a copy of that repository and performed a project search for "aphylogeo" (case insensitive) but wasn't able to locate the parts of the pipeline it was integrated into.

Thank you for reaching out, and I appreciate your attention to detail in reviewing the repository. In the pipeline, aPhyloGeo is referenced within the broader analytical workflow rather than as a distinct importable package (sorry for this confusion). It is embedded through specific scripts that address co-phylogenetic analyses, including tree construction and congruence metrics between bat hosts and CoVs. These scripts, which use RAxML for phylogeny inference and PACo for congruence analysis, do not explicitly use "aPhyloGeo" as a named module but rather reference this process as part of the complete aPhyloGeo pipeline.

For a direct view of this integration, I recommend checking the workflow scripts (e.g., Snakefile) for pipeline steps involving phylogenetic alignment, tree reconciliation, and the Robinson–Foulds distance. These components represent the core functions associated with aPhyloGeo's intended cophylogenetic analysis, although the term itself may not appear in a standalone form in the code.

@TahiriNadia
Copy link

The most recent peer-reviewed study directly addressing Cumacea is as follows:

4️⃣ Gagnon, J. & Tahiri, N. (2024). Ecological and Spatial Influences on the Genetics of Cumacea (Crustacea: Peracarida) in the Northern North Atlantic. Proceeding in SciPy 2024, Tacoma, WA, USA

@TahiriNadia
Copy link

image

@TahiriNadia
Copy link

4️⃣ Gagnon, J. & Tahiri, N. (2024). Ecological and Spatial Influences on the Genetics of Cumacea (Crustacea: Peracarida) in the Northern North Atlantic. Proceeding in SciPy 2024, Tacoma, WA, USA

aPhyloGeo is included as a step in our analysis, as shown in the pipeline provided in this paper.

image

@TahiriNadia
Copy link

Dear Editor @arfon,

We sincerely thank the reviewers, @mmore500 and @theosanderson, for their valuable feedback, which has greatly improved the quality and clarity of our manuscript. Following their insightful comments, we have carefully addressed each requested modification. We removed self-references to enhance objectivity, and we simplified the pipeline figure. We also reviewed and ensured the precision of all decimal points in statistical tests to maintain rigorous accuracy and also the path. The licensing issue for the package was resolved by removing the bin directory, which was deemed unnecessary.

To further demonstrate the tool's value and originality, we conducted additional analyses showcasing its utility in unique ways, confirming that no existing package matches the specific functionalities of aPhyloGeo. Furthermore, we illustrated the tool’s application in peer-reviewed publications, underscoring its relevance and robustness in research contexts. Finally, we carefully revised the manuscript to reduce its length without compromising the quality of the content, ensuring a concise and focused presentation.

Sincerely,
Nadia Tahiri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perl Python review Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants