-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: MOTrainer: Distributed Measurement Operator Trainer for Data Assimilation Applications #6591
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
👋🏼 @rogerkuou @abhishektiwari @KwickSilver this is the review thread for the paper. All of our communications will happen here from now on. As you might know, as a reviewer, the first step is to create a checklist for your review by entering @editorialbot generate my checklist as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#REVIEW_NUMBER so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@srmnitc ) if you have any questions/concerns, thanks again for the submission, and for thr reviews |
Hi Sarath,
Apologies for my delayed response; I haven't been able to start reviewing
the journal yet. I plan to begin tomorrow and aim to complete it by the end
of this month. Does this timeline work for you?
Thanks,
Shantanu
…On Mon, 8 Apr 2024 at 04:47, Sarath Menon ***@***.***> wrote:
👋🏼 @rogerkuou <https://github.com/rogerkuou> @abhishektiwari
<https://github.com/abhishektiwari> @KwickSilver
<https://github.com/KwickSilver> this is the review thread for the paper.
All of our communications will happen here from now on.
As you might know, as a reviewer, the first step is to create a checklist
for your review by entering
@editorialbot <https://github.com/editorialbot> generate my checklist
as the top of a new comment in this thread.
These checklists contain the JOSS requirements. As you go over the
submission, please check any items that you feel have been satisfied. The
first comment in this thread also contains links to the JOSS reviewer
guidelines.
The JOSS review is different from most other journals. Our goal is to work
with the authors to help them meet our criteria instead of merely passing
judgment on the submission. As such, the reviewers are encouraged to submit
issues and pull requests on the software repository. When doing so, please
mention openjournals/joss-reviews#REVIEW_NUMBER so that a link is created
to this thread (and I can keep an eye on what is happening). Please also
feel free to comment and ask questions on this thread. In my experience, it
is better to post comments/questions/suggestions as you come across them
instead of waiting until you've reviewed the entire package.
We aim for reviews to be completed within about 2-4 weeks. Please let me
know if any of you require some more time. We can also use EditorialBot
(our bot) to set automatic reminders if you know you'll be away for a known
period of time.
Please feel free to ping me ***@***.*** <https://github.com/srmnitc> ) if
you have any questions/concerns, thanks again for the submission, and for
thr reviews
—
Reply to this email directly, view it on GitHub
<#6591 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCUHHJ5AU25RZTRQPVGMKDY4J7VBAVCNFSM6AAAAABF4RFJNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSGUZTQOBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@KwickSilver that is fine, thanks for the update! |
@abhishektiwari hi! just a short reminder about the review, do you need anything from our side to get started? |
Review checklist for @abhishektiwariConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@rogerkuou Initial feedback,
Once you have fixed these, let us know in comments here so I can verify functional claims. |
Thx @abhishektiwari for the feedback! Sorry for the late reply, just came back from a holiday. I will work on them in the coming days, and will let you know when it's done. |
@KwickSilver hi! just a short reminder from my side for the review here. |
@srmnitc Apologies for the delay. Due to competing priorities, I was unable to allocate sufficient time for the review as promptly as I had intended. However, I will commence the review process without further delay. |
Review checklist for @KwickSilverConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks for your quick reply! |
@rogerkuou just a quick ping to see how the changes are coming along, please dont forget to leave a message here once you are done. Thanks! |
Done! version is now v1.0.7 |
@rogerkuou thanks a lot for all the changes from your side. Everything looks good to me. I will now pass it on our editor in charge who will finish the rest of the steps. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5785, then you can now move forward with accepting the submission by compiling again with the command |
And once again, thanks for your patience too :) |
Hi @srmnitc sorry for bothering you again, but seems you set the version to v1.0.7. The version I released is v0.1.7. I should have noticed this earlier. Maybe it can be easily changed? I am not sure if I can use the set version command from editorialbot. And again, thanks a lot for the editorial work! |
@editorialbot set v0.1.7 as version just jumping in with a quick fix... |
Done! version is now v0.1.7 |
Thanks a lot! |
🔍 checking out the following:
|
@editorialbot generate pdf |
👋 @rogerkuou - I need you to address the following before I can move to accept this one for publication.
In the paper:
Let me know once you address these and I will move to accept the paper. |
@editorialbot generate pdf |
Hi @crvernon, thanks a lot for the review! The Zenodo repo title and metadata file. Now the title strictly matches the JOSS paper The reference capitalization has been solved by this PR: VegeWaterDynamics/motrainer#132 |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🥳 Congratulations on your new publication @rogerkuou! Many thanks to @srmnitc for editing and @abhishektiwari and @WarmCyan for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks all for your time and work! @srmnitc @abhishektiwari @WarmCyan @crvernon 🥳 |
Submitting author: @rogerkuou (Ou Ku)
Repository: https://github.com/VegeWaterDynamics/motrainer
Branch with paper.md (empty if default branch):
Version: v0.1.7
Editor: @srmnitc
Reviewers: @abhishektiwari, @WarmCyan
Archive: 10.5281/zenodo.13349186
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@abhishektiwari & @KwickSilver, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @srmnitc know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @abhishektiwari
📝 Checklist for @KwickSilver
📝 Checklist for @WarmCyan
The text was updated successfully, but these errors were encountered: