-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models #6752
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
👋🏼 @gartavanis, @JannisHoch & @dvalters, this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step, as mentioned in the first comment of this issue, is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please notify me if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please don't hesitate to ping me ( |
Hi @JannisHoch and @dvalters, a friendly reminder for reviewing this submission. |
Review checklist for @dvaltersConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I'm part way through the review and just waiting for a PIN/registration process to complete so I can access the ParFlow data for testing. Will continue once this is received |
@dvalters Thank you for the update. Also, please let me know about your experience with the process of getting the PIN. |
Review checklist for @JannisHochConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @cheginit The software meets all the requirements to be accepted by JOSS and I suggest it be accepted as is. Getting the PIN and registering it to access the sample data was fairly straightforward. I could not get every single test to run on my machine, however I suspect that is down to requiring extra data sources for certain tests that I don't have. The software clearly has a fairly comprehensive suite of tests and I'm happy for it to pass that criteria without me needing to verify every single unit test. (which I would not have time to do)
A nice piece of software @gartavanis 👍 |
sorry for being slow with the review, will work on it next week |
@dvalters Thanks for taking the time to review the package. Usually, @JannisHoch Thanks for the update. |
@cheginit yes I was able to invoke the test suite using |
@dvalters I see. In that case, I'd appreciate it if you open an issue in their repo and report the failing tests, i.e., the log of running |
:wave @JannisHoch, just a friendly reminder about this review. |
@cheginit what's the definition of "original data" and "original results"? |
@JannisHoch In this context, original means that the data and results are produced for/by the software. For example, original data means that new data has been prepared for running the software and original results mean that the software produced new results that must be verifiable by following the instructions provided by the authors. |
Great thanks. I created two issues. Once satisfactorily adressed, I will proceed with the review. |
@JannisHoch Awesome, thanks for the update! |
@JannisHoch A friendly reminder for this revidw. |
@gartavanis We're almost there! Please check the "Additional Author Tasks" in the previous comment and do those tasks, so I can move on to recommending acceptance! |
@cheginit, I have created a new release of subsettools (https://github.com/hydroframe/subsettools/releases/tag/2.0.1). It's also on PyPI. This is version 2.0.1. The Zenodo archive is here: https://zenodo.org/records/12707059. (DOI: 10.5281/zenodo.12707059). Please let me know if there's anything else that remains to be done on our end. Thanks again for your time! |
@editorialbot set v2.0.1 as version |
Done! version is now v2.0.1 |
@editorialbot set 10.5281/zenodo.12707059 as archive |
Done! archive is now 10.5281/zenodo.12707059 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5600, then you can now move forward with accepting the submission by compiling again with the command |
@gartavanis Thanks for working on addressing the issues diligently and congrats on making it this far! The EiC will take over the submission for the final publication, in the meanwhile, please check the final proof of the paper in the previous comment, just to make sure everything looks good such as authors' names. |
The final proof looks good. Thank you @cheginit, @dvalters and @JannisHoch for your time, suggestions and the smooth review process! |
Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!
|
Hi @gartavanis, I see that the version is |
Paper:
|
Hi @kthyng, thanks for the comments! I added the version number on Zenodo and the middle initials. |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your new publication @gartavanis! Many thanks to @cheginit and to reviewers @JannisHoch and @dvalters for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @gartavanis (Georgios Artavanis)
Repository: https://github.com/hydroframe/subsettools
Branch with paper.md (empty if default branch): joss-paper
Version: v2.0.1
Editor: @cheginit
Reviewers: @JannisHoch, @dvalters
Archive: 10.5281/zenodo.12707059
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@JannisHoch & @dvalters, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @cheginit know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @dvalters
📝 Checklist for @JannisHoch
The text was updated successfully, but these errors were encountered: