-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pyPLNmodels: A Python package to analyse multivariate high-dimensional count data #6969
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@LingfengLuo0510 @mrazomej this is the issue for the review! Let me know if you have any questions - more info can also be found here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html |
@editorialbot generate pdf Figures were not displayed. |
@editorialbot generate pdf nicer color in figure. |
@editorialbot generate pdf |
Review checklist for @mrazomejConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
First, I must apologize for the delayed comments on this submission. There are two main comments I would like to make about the state of the software and the paper.
2.a Fig. 2 does not have a caption that explains, among other things, what the legend labels are. Furthermore, when doing this kind of comparison, it would be handy to highlight which of the curves are directly related to your software. Something that can be added in a detailed caption or in the legend, something like These are my first two initial comments. These changes are necessary for me to properly assess the software and the entire submission, as I need the most basic tools to understand the software's core functionality. From what I can get from glancing at the previous publications, this is an exciting piece of software. But my understanding is that, as a |
Thank you for your comments and suggestions. We have carefully Documentation:
Manuscript:
We hope these revisions enhance the clarity and comprehensibility of our work. Thank you for your time. |
@editorialbot generate pdf |
@editorialbot generate pdf |
@Bastien-mva , thanks for the changes. In my opinion, the software is much better. |
Sorry for the delayed comments Here are my comments: |
Thanks you for your comments. We have carefully considered them and made the All points not explicitly mentioned were @mrazomej @LingfengLuo0510, |
@editorialbot generate pdf |
@Bastien-mva Other than that, good to go here. @likeajumprope |
I have added the link in the bibliography and corrected the capitalization in 'Bound'. |
@editorialbot generate pdf |
@likeajumprope I believe I have addressed all the comments. Is there anything further I need to do at this stage? |
No thanks, I will have a look! |
Submitting author: @Bastien-mva (Bastien Batardiere)
Repository: https://github.com/PLN-team/pyPLNmodels.git
Branch with paper.md (empty if default branch): joss
Version: 0.0.78
Editor: @likeajumprope
Reviewers: @LingfengLuo0510, @mrazomej
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@LingfengLuo0510 & @mrazomej, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @likeajumprope know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @mrazomej
The text was updated successfully, but these errors were encountered: