Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Bodge: Python package for efficient tight-binding modeling of superconducting nanostructures #6991

Closed
editorialbot opened this issue Jul 15, 2024 · 38 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 15, 2024

Submitting author: @jabirali (Jabir Ali Ouassou)
Repository: https://github.com/jabirali/bodge/
Branch with paper.md (empty if default branch): paper
Version: v1.1.0
Editor: @phibeck
Reviewers: @sabinomaggi, @yw-fang, @mdavezac
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/18b48f694511e8c02a6b56375855fd0c"><img src="https://joss.theoj.org/papers/18b48f694511e8c02a6b56375855fd0c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/18b48f694511e8c02a6b56375855fd0c/status.svg)](https://joss.theoj.org/papers/18b48f694511e8c02a6b56375855fd0c)

Author instructions

Thanks for submitting your paper to JOSS @jabirali. Currently, there isn't a JOSS editor assigned to your paper.

@jabirali if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Jul 15, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1103/PhysRevLett.131.076003 is OK
- 10.1103/PhysRevB.109.174506 is OK
- 10.48550/arXiv.2407.07144 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1007/978-3-319-31314-6 is OK
- 10.1088/1367-2630/16/6/063065 is OK
- 10.5281/zenodo.4010216 is OK

MISSING DOIs

- 10.1201/9780429497032 may be a valid DOI for title: Superconductivity of metals and alloys

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1001.8 files/s, 217385.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSS                              4             39             19           2238
JavaScript                      11            235            226           2112
HTML                             2             34              4            927
Python                           8            294            361            765
Markdown                         3             50              0            142
TeX                              1              8              0             86
YAML                             3              9              4             64
CSV                              1              0              0             45
JSON                             1              0              0             44
make                             1             14              5             43
TOML                             1              6              0             38
-------------------------------------------------------------------------------
SUM:                            36            689            619           6504
-------------------------------------------------------------------------------

Commit count by author:

   512	Jabir Ali Ouassou
     5	Jabir Ouassou

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1268

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

lattice-symmetries: A package for working with quantum many-body bases
Submitting author: @twesterhout
Handling editor: @jedbrown (Active)
Reviewers: @jeffhammond, @joselado
Similarity score: 0.7263

QuantNBody: a Python package for quantum chemistry and physics to build and manipulate many-body operators and wave functions.
Submitting author: @SYalouz
Handling editor: @jarvist (Retired)
Reviewers: @wcwitt, @erikkjellgren
Similarity score: 0.7151

matador: a Python library for analysing, curating and performing high-throughput density-functional theory calculations
Submitting author: @ml-evs
Handling editor: @jgostick (Active)
Reviewers: @mkhorton, @srmnitc
Similarity score: 0.7151

The Walrus: a library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling
Submitting author: @nquesada
Handling editor: @katyhuff (Retired)
Reviewers: @amitkumarj441, @poulson
Similarity score: 0.7057

SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency
Submitting author: @antoinediez
Handling editor: @pdebuyl (Active)
Reviewers: @lorenzo-rovigatti, @junghans
Similarity score: 0.7052

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

Hi @jabirali, thanks for your submission. Due to the relatively small nature of your package, the JOSS editorial board is going to take a look to make sure it meets our requirements for substantial scholarly effort before proceeding to review. We should get back to you within a week or two at most.

@kyleniemeyer
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jul 15, 2024
@kyleniemeyer kyleniemeyer removed the query-scope Submissions of uncertain scope for JOSS label Aug 5, 2024
@kyleniemeyer
Copy link

@jabirali we will proceed a review of your submission, @phibeck has agreed to edit

@kyleniemeyer
Copy link

@editorialbot invite @phibeck as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@phibeck
Copy link

phibeck commented Aug 5, 2024

@editorialbot assign @phibeck as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @phibeck is now the editor

@phibeck
Copy link

phibeck commented Aug 7, 2024

Hi @jabirali, thanks for your submission. I'll be looking for reviewers next. If you have a moment, it would be helpful if you could identify a few potential reviewers from this list https://reviewers.joss.theoj.org/reviewers (without tagging them with an @).

@jabirali
Copy link

jabirali commented Aug 9, 2024

Dear @phibeck,

Thanks a lot for agreeing to edit my submission! I have now had a look through the list of reviewers, and I believe the following referees (listed by their GitHub handle) might be relevant to my submission:

  • alejandrojuria
  • yw-fang
  • kaelynj
  • santoshkumarradha
  • nmoran
  • sabinomaggi

I didn't find any referees in the system with a background in the particular framework I've implemented, but the suggestions above all appear to have some background in condensed matter physics and experience with either tight-binding models or superconductivity. I therefore believe they should be qualified to judge my submission.

Kind Regards, Ali.

@phibeck
Copy link

phibeck commented Aug 9, 2024

👋 @alejandrojuria, @sabinomaggi & @yw-fang, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@sabinomaggi
Copy link

Hi @phibeck, I guess I could do that, but I am on vacation now until the end of the month and will be attending a couple of conferences in the first half of September. Until then I could read the paper, but I will not be able to check things like installation or functionality of the package.

@phibeck
Copy link

phibeck commented Aug 13, 2024

Hi @sabinomaggi okay thanks for letting me know and for agreeing to review. I think this should be fine, I will assign you as reviewer keeping your timeline in mind.

@phibeck
Copy link

phibeck commented Aug 13, 2024

@editorialbot add @sabinomaggi as reviewer

@editorialbot
Copy link
Collaborator Author

@sabinomaggi added to the reviewers list!

@phibeck
Copy link

phibeck commented Aug 13, 2024

👋 @kaelynj, @santoshkumarradha & @nmoran, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@yw-fang
Copy link

yw-fang commented Aug 13, 2024 via email

@phibeck
Copy link

phibeck commented Aug 13, 2024

Hi @yw-fang, thank you very much for agreeing to review!

@phibeck
Copy link

phibeck commented Aug 13, 2024

@editorialbot add @yw-fang as reviewer

@editorialbot
Copy link
Collaborator Author

@yw-fang added to the reviewers list!

@phibeck
Copy link

phibeck commented Aug 19, 2024

👋 @WangYiXu92, @flokno & @mdavezac, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@kaelynj
Copy link

kaelynj commented Aug 19, 2024

Hi Sophie,

If reviewers are still needed for this, I'm happy to spend some time doing so.

Cheers,
Kaelyn

@mdavezac
Copy link

I'm happy to review this

@flokno
Copy link

flokno commented Aug 21, 2024

If more reviewers are needed, I can contribute as well!

@phibeck
Copy link

phibeck commented Aug 22, 2024

Hi @kaelynj, @mdavezac and @flokno thank you all for your responses. At this point we only need one more reviewer, so I'll take @mdavezac's offer, but might get back to you at a later point in case we need one more.

@phibeck
Copy link

phibeck commented Aug 22, 2024

@editorialbot add @mdavezac as reviewer

@editorialbot
Copy link
Collaborator Author

@mdavezac added to the reviewers list!

@phibeck
Copy link

phibeck commented Aug 22, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7134.

@sabinomaggi
Copy link

@phibeck Hi Sophie, sorry for being late but I just came back from my holidays and I found a nice surprise, I have to move all my office elsewhere because of some maintenance work. Therefore if two reviewers are enough for you, please go ahead without my review.

@phibeck
Copy link

phibeck commented Sep 15, 2024

Thanks @sabinomaggi for your response. Since this Pre Review issue is closed, I copied your response into the Review issue and answered there.

Okay, thanks for letting me know. If we have two completed reviews that would be fine. In the event that another reviewer drops out, may I contact you again or rather not at the moment?

Originally posted by @phibeck in #7134 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants