Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to author names in docs #1262

Closed
3 tasks done
cliffckerr opened this issue Aug 23, 2023 · 3 comments · Fixed by openjournals/inara#39
Closed
3 tasks done

Broken link to author names in docs #1262

cliffckerr opened this issue Aug 23, 2023 · 3 comments · Fixed by openjournals/inara#39

Comments

@cliffckerr
Copy link

cliffckerr commented Aug 23, 2023

The JOSS docs say:

For a complete description of available options to describe author names see here.

A couple suggestions:

  • The link gives a 404. I think it just needs to point to https://github.com/openjournals/inara/blob/main/docs/names.md, although the default display of this file on GitHub leaves a little to be desired, so maybe a Read the Docs link would be preferable if available?
  • It would also be nice to have even a very brief explanation of how these choices differ, e.g. dropping vs. non-dropping particles.
  • Would suggest changing "Western" to "English" or "Anglo-Saxon", since "Ludwig van Beethoven" and "Louis de Broglie" are pretty Western 😁
@danielskatz
Copy link
Collaborator

Thanks @cliffckerr - would you want to create a PR with your suggested changes?

@cliffckerr
Copy link
Author

Have made a PR -- oddly I can't reproduce the 404 I was getting before! Maybe it was already fixed but I was looking at an old version of the docs?

@kthyng
Copy link
Contributor

kthyng commented Aug 23, 2023

I think this might have just changed recently — @arfon didn't you just update this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants