-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimise diff between our CoC & upstream by adjusting titles & newlines #1007
Conversation
Requesting fast-tracking for this, as its a purely stylistic change which makes comparisons to the upstream much easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The soft wrapping was an intentional decision - hard wrapping is horrific for editing and diff churn - but i agree that creating an excessive diff from upstream isn't worth the benefit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 <3 <3
Actually, we never changed the wrapping from how it was when we copied it. It's the upstream that has subsequently applied hard wrapping to the text. This change aligns our wrapping with the current state of the upstream v2.1 text, effectively backporting stylistic updates to our copy. |
@eemeli ah, i'd remembered it wrong. then it's just a really unfortunate upstream decision. |
I believe we agreed to ship this today because it's supposed to minimize the diff prior to landing #972 |
…les & newlines (#1007) Co-authored-by: Tierney Cyren <accounts@bnb.im>
As identified in far too many discussions, our upstream CoC is not stable. This PR does not apply any changes to the textual content of our CoC, but adjusts the line wrapping and title levels to minimise the difference between our text and the latest upstream text, v2.1.
After this is merged, it becomes somewhat easier to consider each of the four remaining parts of the diff separately:
1. Embedding the doc to within our
CODE_OF_CONDUCT.md
Skipping here all the text before the
---
separator.2. Adding our contact methods
3. Differences between the v2.0 and v2.1 versions of the upstream
The terms "caste" and "color" were added in v2.1.
4. Retaining the "project" specifier for perma-bans
This was dropped from the upstream after our copy was taken as an apparently missed part of the v1.4 -> v2.0 updates.