Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds proposal for charter submission & review per #200 #405

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

jorydotcom
Copy link
Contributor

Adds a charter submission and review process to address this need for project onboarding.

proposals/stage-1/CHARTER_REVIEW/charter_review.md Outdated Show resolved Hide resolved
## How would success be measured?

* speed and thoroughness of charter review - we have ~30 project charters to assess in the coming months related to onboarding
* ease of review - the process should be relatively frictionless where there are no concerns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should track progress with some tool, 30 are a LOT!

* Reviewing CPC members have added themselves as reviewers on the issue and approved.
* More than 50% of voting CPC members have approved, OR
* More than 2/3 of all CPC members have approved, OR
* A period of 14 days has elapsed with no concerns or objections raised.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This https://github.com/openjs-foundation/cross-project-council/blob/master/GOVERNANCE.md#aproving-project-charters in the governance doc says:

The request is approved when:

there are no outstanding objections
there are two or more approvals by voting CPC members
the board has been consulted in the case of substantial changes
The issue has been open for at least 14 days

I'd suggest we use that, and possibly just link to that so we don't need to maintain in 2 places

@MylesBorins
Copy link
Contributor

Seems like this proposal got forgotten about. Considering we are already approving of charters do we still need this formalized to this extent?

Copy link
Contributor Author

@jorydotcom jorydotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson updated to link to the governance doc. Look ok?

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jan 9, 2020

@jorydotcom link looks perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants