Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details regarding research process #7

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

Ethan-Arrowood
Copy link
Collaborator

After working through some research for the name field I realized that we should clarify exactly what the analysis should include. I don't want to see (or waste my own time) researching how an endless number of package managers utilize various properties. Instead, I want the research to focus on exactly how the properties should be defined in a package.json.

I've included an example that I hope makes sense to help further demonstrate the clarification

@darcyclarke
Copy link
Member

I think I understand now what you were explaining on our call just now in regards to trying to map/research values vs. usage. That said, I still think it will be hard to reason about what values could be without understanding usage. You're going to find, as I have historically, that the documentation for these values is often incomplete or inaccurate & the truth lays in the code that ingests them.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ethan-Arrowood
Copy link
Collaborator Author

@darcyclarke & @ljharb I've rewritten the section to reflect our recent meeting discussion. Please review and let me know your thoughts 😄

@Ethan-Arrowood Ethan-Arrowood merged commit 6f7c892 into main Jan 12, 2024
@Ethan-Arrowood Ethan-Arrowood deleted the add-process-details branch January 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants