You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Frontend message is correct in hiding whether the user or password is incorrect (Incorrect login ID or password), however, inspecting response body shows the difference. Message for existing user is "authentication failed: authentication failed for mstein: authentication failed", and the message for non-existent user is "authentication failed: authentication failed for janko: authentication failed: Not found: user janko". Such information should not be revealed.
Error message propagated to the browser should be the same whether username exists or not - authentication failed
Update tests, if required
The text was updated successfully, but these errors were encountered:
SamuelPull
changed the title
Don't give extra information on failed login: Frontend message is correct in hiding whether the user or password is incorrect (Incorrect login ID or password), however, inspecting response body shows the difference. Message for existing user is "authentication failed: authentication failed for mstein: authentication failed", and the message for non-existent user is "authentication failed: authentication failed for janko: authentication failed: Not found: user janko". Such information should not be revealed.
Don't give extra information on failed login
Jul 25, 2023
Frontend message is correct in hiding whether the user or password is incorrect (
Incorrect login ID or password
), however, inspecting response body shows the difference. Message for existing user is"authentication failed: authentication failed for mstein: authentication failed"
, and the message for non-existent user is"authentication failed: authentication failed for janko: authentication failed: Not found: user janko"
. Such information should not be revealed.authentication failed
The text was updated successfully, but these errors were encountered: