Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: hide 400 error details from user #1425

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Jul 25, 2023

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Please see #1424 .
To test, try logging in with existing user and incorrect password. Try logging in with non-existing user.
Message in the body of http response should be the same.
API logs are unchanged: ifferent error messages are published in these scenarios. It's just the details going back to the client that are censored.

Closes #1424

@github-actions
Copy link

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against e1e2fa0

@openkfwCI
Copy link

openkfwCI commented Jul 25, 2023

NotesTime
Note for Reviewer: E2E tests on remote server succeededTue, 25 Jul 2023 13:03:09 +0000

Generated by E2E-Test

@SamuelPull SamuelPull marked this pull request as ready for review July 25, 2023 13:06
@andrea-smiesna andrea-smiesna merged commit 4fb492b into main Jul 25, 2023
28 checks passed
@andrea-smiesna andrea-smiesna deleted the 1424-hide-authentication-details branch July 25, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't give extra information on failed login
3 participants