Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate assignee when creating workflow item #1334

Merged
merged 9 commits into from
Apr 17, 2023

Conversation

egdmrsy
Copy link
Contributor

@egdmrsy egdmrsy commented Apr 6, 2023

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

2 validations on API Level are added:
1- Disabled users are not allowed to be assigned to workflow items.
2- Users that do not exist are not allowed to be assigned to workflow items.

Closes #1327

@egdmrsy egdmrsy self-assigned this Apr 6, 2023
@egdmrsy egdmrsy force-pushed the 1327-wfi-check-assignee-exists branch from 85caaf3 to 20a6785 Compare April 6, 2023 11:56
@egdmrsy egdmrsy requested a review from georgimld April 6, 2023 12:45
@openkfwCI
Copy link

openkfwCI commented Apr 6, 2023

NotesTime
Note for Reviewer: E2E tests on remote server succeededMon, 17 Apr 2023 12:49:21 +0000

Generated by E2E-Test

@georgimld georgimld self-assigned this Apr 11, 2023
@egdmrsy egdmrsy force-pushed the 1327-wfi-check-assignee-exists branch from 96a0c66 to d86dd31 Compare April 11, 2023 11:41
@egdmrsy egdmrsy force-pushed the 1327-wfi-check-assignee-exists branch from cdaa234 to 4f64d2f Compare April 17, 2023 12:03
@georgimld georgimld merged commit e8128dc into main Apr 17, 2023
@georgimld georgimld deleted the 1327-wfi-check-assignee-exists branch April 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow items with non-existing assignee cannot be modified
3 participants