Exclude rejected WFI from assigned budget #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by E2E-Test |
georgimld
reviewed
Apr 19, 2023
georgimld
requested changes
Apr 19, 2023
There was a problem hiding this comment.
- add e2e-tests here https://github.com/openkfw/TruBudget/blob/main/e2e-test/cypress/integration/subproject_analytics_spec.js
- add changelog entry for fixing the bug
egdmrsy
force-pushed
the
1275-amount-of-rejected-wfi-on-dashboard
branch
from
3e1867d
to
fb3affd
Compare
georgimld
approved these changes
Apr 25, 2023
egdmrsy
force-pushed
the
1275-amount-of-rejected-wfi-on-dashboard
branch
2 times, most recently
from
029d960
to
fb3affd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Added a check for rejected workflow items before calculating the assigned budget for project and subproject detail views.
Closes #1275