api:additional check for token inside error #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by E2E-Test |
egdmrsy
force-pushed
the
1367-missing-token-crashes-server
branch
from
d5ad199
to
87a084c
Compare
SamuelPull
reviewed
May 29, 2023
egdmrsy
force-pushed
the
1367-missing-token-crashes-server
branch
from
7e6cdcf
to
fdca698
Compare
egdmrsy
requested review from
SamuelPull and
georgimld
and removed request for
SamuelPull
georgimld
reviewed
Jun 7, 2023
CHANGELOG.md
Outdated
| @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Fixed a bug where missing token would crash the api. [#1367](https://github.com/openkfw/TruBudget/issues/1367) | |||
There was a problem hiding this comment.
no need for changelog entry, as the bug is not relevant for Trubudget users or operators
egdmrsy
force-pushed
the
1367-missing-token-crashes-server
branch
from
f9106f0
to
d8bf018
Compare
georgimld
approved these changes
Jun 7, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Closes #1367
Closes #1389
Added additional check for the token inside error. If it is undefined, userId is not printed in the log.