1103 rpc client logs expected error #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayrmartin
approved these changes
Sep 25, 2023
egdmrsy
force-pushed
the
1103-rpc-client-logs-expected-error
branch
from
b957b73
to
e1d985e
Compare
…ethod to avoid code duplication and redundant error logging.
…xists, before sending create command. (Avoiding invoke errors)
egdmrsy
force-pushed
the
1103-rpc-client-logs-expected-error
branch
from
e1d985e
to
f4fde0b
Compare
Generated by E2E-Test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Closes #1103
The low-level RPC-Client method "invoke" logs errors from Multichain regardless of the error-handling on high-level methods that call it. When trying to create a stream that exists on the chain, Multichain throws a -705 error, which is logged by the RPC-Client. This is not desirable for the ensureStreamExists/getOrCreateStream functions, because these functions are meant to return a stream if such stream exists and therefore should not throw an error in such case. That's why the solution is to send an additional network request with "liststreams" command to check if the desired stream exists. In that case the "create stream" command will be bypassed as well as the error it returns.