Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthBuddy update (including metadata written to chain) #1468

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Sep 26, 2023

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Closes #1432
Closes #1449
Closes #1457
Closes #1458

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Warnings
⚠️ There were changes in the frontend, but no E2E-test was added or modified!
⚠️ A new TODO was added.

Generated by 🚫 dangerJS against 1edd3f7

@openkfwCI
Copy link

openkfwCI commented Sep 27, 2023

NotesTime
Note for Reviewer: E2E tests on remote server failedThu, 05 Oct 2023 12:27:35 +0000

Generated by E2E-Test

@@ -213,7 +217,7 @@ services:
restart: always
build:
context: ../../frontend
dockerfile: Dockerfile.dev
dockerfile: Dockerfile
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants