Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1490 fix documentation and dev setup #1492

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

egdmrsy
Copy link
Contributor

@egdmrsy egdmrsy commented Oct 24, 2023

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Closes #1490

@egdmrsy egdmrsy force-pushed the 1490-fix-documentation-and-dev-setup branch from 1893340 to 1e6a75c Compare October 24, 2023 10:58
@openkfwCI
Copy link

openkfwCI commented Oct 24, 2023

NotesTime
Note for Reviewer: E2E tests on remote server succeededWed, 29 Nov 2023 11:19:57 +0000

Generated by E2E-Test

@egdmrsy egdmrsy marked this pull request as ready for review November 8, 2023 10:48
@egdmrsy egdmrsy force-pushed the 1490-fix-documentation-and-dev-setup branch from 14b1617 to 6d5f5dc Compare November 9, 2023 11:09
@egdmrsy egdmrsy force-pushed the 1490-fix-documentation-and-dev-setup branch 3 times, most recently from 1f0f560 to 6808cd8 Compare November 10, 2023 10:24
@egdmrsy egdmrsy force-pushed the 1490-fix-documentation-and-dev-setup branch from e86a56b to b3b6f2f Compare November 24, 2023 12:24
@SamuelPull
Copy link
Collaborator

@egdmrsy Please squash the commits into one before merging.

@egdmrsy egdmrsy force-pushed the 1490-fix-documentation-and-dev-setup branch from 86e1463 to a3dc61a Compare November 29, 2023 09:14
fix documentation link to trubudget-website

added .env to gitignore and removed it from repo

renamed .env_example to correct naming

renamed .env_example to correct naming

updated environment variables section for developer setup

docs:fixed the env-variable table

docs: fixed remaining env.example files and references

cleaning up remaining .env_example references

fixed wrong environment variable name for blockchain

ignoring vulnerability 1094762

changed gitignore

added .env back to repo

removed axios vulnerability from ignore list as it is fixed

solved the issue where react app version had to be passed to the application
@egdmrsy egdmrsy force-pushed the 1490-fix-documentation-and-dev-setup branch from a3dc61a to 9aa3d74 Compare November 29, 2023 10:45
@egdmrsy egdmrsy merged commit 0942328 into main Nov 29, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix documentation and developer setup/script
3 participants