Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: set default analytics currency #1497

Merged
merged 1 commit into from
Oct 30, 2023
Merged

ui: set default analytics currency #1497

merged 1 commit into from
Oct 30, 2023

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Oct 24, 2023 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Closes #1489

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 18a25c2

@openkfwCI
Copy link

openkfwCI commented Oct 24, 2023 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededMon, 30 Oct 2023 13:36:57 +0000

Generated by E2E-Test

@SamuelPull SamuelPull force-pushed the 1489-analytics-default-currency branch from c08d4af to 1cce6a2 Compare October 24, 2023 14:10
@SamuelPull SamuelPull marked this pull request as ready for review October 25, 2023 06:42
@SamuelPull SamuelPull force-pushed the 1489-analytics-default-currency branch from 1cce6a2 to 0fa274b Compare October 25, 2023 06:42
@SamuelPull SamuelPull force-pushed the 1489-analytics-default-currency branch from 0fa274b to 5b585c2 Compare October 30, 2023 12:25
@mayrmartin mayrmartin force-pushed the 1489-analytics-default-currency branch from 5b585c2 to 18a25c2 Compare October 30, 2023 12:41
@mayrmartin mayrmartin merged commit 8cdf1f0 into main Oct 30, 2023
29 checks passed
@mayrmartin mayrmartin deleted the 1489-analytics-default-currency branch October 30, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egdmrsy egdmrsy egdmrsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set dashboard default currency to project currency
4 participants
@SamuelPull @openkfwCI @egdmrsy @mayrmartin