Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‼️HIGH PRIORITY: Upgrade axios version to mitigate vulnerability #1526

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Nov 16, 2023

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Updated e2e docker image because node 10 couldn't load updated axios. Maybe importing cjs directly would work. But if 18 passes, I don't see any downside to it.

Closes #1525

@SamuelPull SamuelPull changed the title TB: Upgrade axios HIGH PRIO: Upgrade axios version to mitigate vulnerability Nov 16, 2023
@SamuelPull SamuelPull changed the title HIGH PRIO: Upgrade axios version to mitigate vulnerability ‼️HIGH PRIORITY: Upgrade axios version to mitigate vulnerability Nov 16, 2023
@openkfwCI
Copy link

openkfwCI commented Nov 16, 2023

NotesTime
Note for Reviewer: E2E tests on remote server succeededThu, 16 Nov 2023 08:45:09 +0000

Generated by E2E-Test

@egdmrsy egdmrsy merged commit 494f3f6 into main Nov 16, 2023
29 checks passed
@SamuelPull SamuelPull deleted the 1525-axios-upgrade branch November 21, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability in axios across several services
3 participants