Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1792 Add rate limiter for excel-export-service #1795

Merged
merged 1 commit into from
Apr 26, 2024
Merged

1792 Add rate limiter for excel-export-service #1795

merged 1 commit into from
Apr 26, 2024

Conversation

galethil
Copy link
Collaborator

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. Set RATE_LIMIT to low value, e.g. 3
  2. Create multiple requests to excel service
  4. ...

Closes #1792

@galethil galethil changed the title excel-export-service:Add rate limiter. 1792 Add rate limiter. Apr 23, 2024
@galethil galethil changed the title 1792 Add rate limiter. 1792 Add rate limiter for excel-export-service Apr 23, 2024
@openkfwCI
Copy link

openkfwCI commented Apr 23, 2024 •
edited
Loading

NotesTime
❌Note for Reviewer: E2E tests on pipeline 58680 on remote server failedWed, 24 Apr 2024 13:56:50 +0000

Generated by E2E-Test

@galethil galethil marked this pull request as ready for review April 24, 2024 12:47
@galethil galethil force-pushed the 1792-excel-export-rate-limit branch from f1b2e9d to e5aa685 Compare April 24, 2024 12:48
@galethil galethil merged commit 4bcb533 into main Apr 26, 2024
30 checks passed
@SamuelPull SamuelPull added this to the TruBudget 2.10.0 milestone Apr 26, 2024
@SamuelPull SamuelPull deleted the 1792-excel-export-rate-limit branch April 26, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPull SamuelPull SamuelPull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TruBudget 2.10.0
Development

Successfully merging this pull request may close these issues.

Protect excel-export-service with rate limit
3 participants
@galethil @openkfwCI @SamuelPull