Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1830 update initial setup #1831

Merged
merged 5 commits into from
May 17, 2024
Merged

1830 update initial setup #1831

merged 5 commits into from
May 17, 2024

Conversation

MartinJurcoGlina
Copy link
Collaborator

@MartinJurcoGlina MartinJurcoGlina commented May 14, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

  • added initial-config script that creates all env files and installs npm packages
  • removed unnecessary volume from docker-compose - no need to build api prior to app start
  • adjusted docs accordingly
  • in frontend babel-eslint package changed due to being deprecated to @babel/eslint-parser

How to test

  1. remove dist folder in api and check that app starts correctly and hot reload in api works

Closes #1830

@openkfwCI
Copy link

openkfwCI commented May 14, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 59104 on remote server succeededFri, 17 May 2024 15:31:11 +0000

Generated by E2E-Test

@MartinJurcoGlina MartinJurcoGlina merged commit deb1c75 into main May 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of initial setup
3 participants