Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1861 stretch workflow details dialog #1868

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

pmolnar-dev
Copy link
Collaborator

@pmolnar-dev pmolnar-dev commented Jun 6, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

  • Workflow Details dialog window is now stretched to fill 80% of the screen size at all times
  • this change will eliminate horizontal scroll bar presence
Screenshot 2024-06-06 at 15 24 22

How to test

  1. login
  2. go to projects -> sub projects -> workflow items
  3. select info icon in workflow item and see that dialog window is stretched

Closes #1861

@pmolnar-dev pmolnar-dev requested a review from galethil June 6, 2024 13:26
Copy link

github-actions bot commented Jun 6, 2024

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 005df98

@openkfwCI
Copy link

openkfwCI commented Jun 6, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 59414 on remote server succeededFri, 07 Jun 2024 08:53:44 +0000

Generated by E2E-Test

@galethil galethil merged commit aa4f52f into main Jun 13, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout bug for validation of documents
3 participants