1863 upgrade button #1951
Merged
1863 upgrade button #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJurcoGlina
requested changes
Aug 26, 2024
api/src/app_latest_version.ts
Outdated
| switch (bodyResult.apiVersion) { | ||
| case "1.0": { | ||
| axios | ||
| .get("https://hub.docker.com/v2/repositories/trubudget%2Fapi/tags?page_size=10") |
There was a problem hiding this comment.
I would take this out at least to Constants file
Generated by E2E-Test |
MartinJurcoGlina
requested changes
Aug 27, 2024
| const [latestVersion, setLatestVersion] = useState(null); | ||
|
|
||
| useEffect(() => { | ||
| axios |
There was a problem hiding this comment.
I would take backend calls to api file
| }, []); | ||
|
|
||
| const upgradeApp = useCallback(() => { | ||
| axios |
There was a problem hiding this comment.
same here, should be in api file with other backend calls
| @@ -136,6 +172,13 @@ const StatusTable = (props) => { | |||
| return ( | |||
| <div data-test="status-dashboard" className="table-container"> | |||
| <div className="custom-width"> | |||
| <p> | |||
| New version of TruBudget is available. Backup your data and click{" "} | |||
| <Button onClick={upgradeApp} variant="contained"> | |||
There was a problem hiding this comment.
upgrade button should be probably visible only to root user
There was a problem hiding this comment.
missing error handling on api calls. Non root users are getting error overlay on opening this page, as well as on Upgrade button click
| const [latestVersion, setLatestVersion] = useState(null); | ||
|
|
||
| useEffect(() => { | ||
| axios |
There was a problem hiding this comment.
also, question here would be, if this request should be even called for non root users? If yes, should non root users alway get error in response?
MartinJurcoGlina
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
How to test
upgrade_version.txtwith content "v2.14.0" (if the file was deleted in the meantime)Alternatively if app is started with
start-upgradable-trubudget.shscript it has the ability to restart itself when stopped. The check is based on presence of running api container. If you stop it, the app should restart.You can stop this process by
stop-upgradable-trubudget.shscript.Closes #1863