Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1954-edit project photo upload #1960

Merged
merged 1 commit into from
Sep 10, 2024
Merged

#1954-edit project photo upload #1960

merged 1 commit into from
Sep 10, 2024

Conversation

MartinJurcoGlina
Copy link
Collaborator

@MartinJurcoGlina MartinJurcoGlina commented Sep 3, 2024 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

  • fixed edit project photo upload

How to test

  1. log in
  2. edit existing project and upload some new photo
  3. on submit new project picture should be saved and displayed

Closes #1954

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 431a7ae

@openkfwCI
Copy link

openkfwCI commented Sep 3, 2024 •
edited
Loading

NotesTime
❌Note for Reviewer: E2E tests on pipeline 60268 on remote server failedTue, 03 Sep 2024 16:09:50 +0000

Generated by E2E-Test

@MartinJurcoGlina MartinJurcoGlina merged commit 32cc225 into main Sep 10, 2024
30 checks passed
@MartinJurcoGlina MartinJurcoGlina deleted the 1954-change-project-photo branch September 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galethil galethil galethil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to change photo of projects
3 participants
@MartinJurcoGlina @openkfwCI @galethil